netdev - Re: [PATCH net-next 6/7] net: pch_gbe: convert to use ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251031183525.5b8b8110@kmaincent-XPS-13-7390>
Date: Fri, 31 Oct 2025 18:35:25 +0100
From: Kory Maincent <kory.maincent@...tlin.com>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc: Sudarsana Kalluru <skalluru@...vell.com>, Manish Chopra
 <manishc@...vell.com>, Marco Crivellari <marco.crivellari@...e.com>, Andrew
 Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Sunil Goutham <sgoutham@...vell.com>, Richard
 Cochran <richardcochran@...il.com>, Russell King <linux@...linux.org.uk>,
 Vladimir Oltean <vladimir.oltean@....com>, Simon Horman <horms@...nel.org>,
 Jacob Keller <jacob.e.keller@...el.com>,
 linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 6/7] net: pch_gbe: convert to use ndo_hwtstamp
 callbacks

On Fri, 31 Oct 2025 00:46:06 +0000
Vadim Fedorenko <vadim.fedorenko@...ux.dev> wrote:

> The driver implemented SIOCSHWTSTAMP ioctl command only, but it stores
> configuration in the private data, so it is possible to report it back
> to users. Implement both ndo_hwtstamp_set and ndo_hwtstamp_get
> callbacks. To properly report RX filter type, store it in hwts_rx_en
> instead of using this field as a simple flag. The logic didn't change
> because receive path used this field as boolean flag.
> 
> Signed-off-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
> ---
>  .../ethernet/oki-semi/pch_gbe/pch_gbe_main.c  | 40 +++++++++++--------
>  1 file changed, 24 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
> b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c index
> e5a6f59af0b6..4049137abc40 100644 ---
> a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c +++
> b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c @@ -198,42 +198,40 @@
> pch_tx_timestamp(struct pch_gbe_adapter *adapter, struct sk_buff *skb)
> pch_ch_event_write(pdev, TX_SNAPSHOT_LOCKED); }
>  
> -static int hwtstamp_ioctl(struct net_device *netdev, struct ifreq *ifr, int
> cmd) +static int pch_gbe_hwtstamp_set(struct net_device *netdev,
> +				struct kernel_hwtstamp_config *cfg,
> +				struct netlink_ext_ack *extack)
>  {
> -	struct hwtstamp_config cfg;
>  	struct pch_gbe_adapter *adapter = netdev_priv(netdev);
>  	struct pci_dev *pdev;
>  	u8 station[20];
>  
> -	if (copy_from_user(&cfg, ifr->ifr_data, sizeof(cfg)))
> -		return -EFAULT;
> -
>  	/* Get ieee1588's dev information */
>  	pdev = adapter->ptp_pdev;
>  
> -	if (cfg.tx_type != HWTSTAMP_TX_OFF && cfg.tx_type != HWTSTAMP_TX_ON)
> +	if (cfg->tx_type != HWTSTAMP_TX_OFF && cfg->tx_type !=
> HWTSTAMP_TX_ON) return -ERANGE;
>  
> -	switch (cfg.rx_filter) {
> +	switch (cfg->rx_filter) {
>  	case HWTSTAMP_FILTER_NONE:
>  		adapter->hwts_rx_en = 0;
>  		break;
>  	case HWTSTAMP_FILTER_PTP_V1_L4_SYNC:
> -		adapter->hwts_rx_en = 0;
> +		adapter->hwts_rx_en = cfg->rx_filter;

It seems there is a functional change here.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com