netdev - Re: [RFC mm v5 2/2] mm: introduce a new page type for page pool in page type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251103123942.GA64460@system.software.com>
Date: Mon, 3 Nov 2025 21:39:42 +0900
From: Byungchul Park <byungchul@...com>
To: Toke Høiland-Jørgensen <toke@...hat.com>
Cc: linux-mm@...ck.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel_team@...ynix.com,
	harry.yoo@...cle.com, ast@...nel.org, daniel@...earbox.net,
	davem@...emloft.net, kuba@...nel.org, hawk@...nel.org,
	john.fastabend@...il.com, sdf@...ichev.me, saeedm@...dia.com,
	leon@...nel.org, tariqt@...dia.com, mbloch@...dia.com,
	andrew+netdev@...n.ch, edumazet@...gle.com, pabeni@...hat.com,
	akpm@...ux-foundation.org, david@...hat.com,
	lorenzo.stoakes@...cle.com, Liam.Howlett@...cle.com, vbabka@...e.cz,
	rppt@...nel.org, surenb@...gle.com, mhocko@...e.com,
	horms@...nel.org, jackmanb@...gle.com, hannes@...xchg.org,
	ziy@...dia.com, ilias.apalodimas@...aro.org, willy@...radead.org,
	brauner@...nel.org, kas@...nel.org, yuzhao@...gle.com,
	usamaarif642@...il.com, baolin.wang@...ux.alibaba.com,
	almasrymina@...gle.com, asml.silence@...il.com, bpf@...r.kernel.org,
	linux-rdma@...r.kernel.org, sfr@...b.auug.org.au, dw@...idwei.uk,
	ap420073@...il.com, dtatulea@...dia.com
Subject: Re: [RFC mm v5 2/2] mm: introduce a new page type for page pool in
 page type

On Mon, Nov 03, 2025 at 01:26:01PM +0100, Toke Høiland-Jørgensen wrote:
> Byungchul Park <byungchul@...com> writes:
> 
> > Currently, the condition 'page->pp_magic == PP_SIGNATURE' is used to
> > determine if a page belongs to a page pool.  However, with the planned
> > removal of ->pp_magic, we should instead leverage the page_type in
> > struct page, such as PGTY_netpp, for this purpose.
> >
> > Introduce and use the page type APIs e.g. PageNetpp(), __SetPageNetpp(),
> > and __ClearPageNetpp() instead, and remove the existing APIs accessing
> > ->pp_magic e.g. page_pool_page_is_pp(), netmem_or_pp_magic(), and
> > netmem_clear_pp_magic().
> >
> > This work was inspired by the following link:
> >
> > [1] https://lore.kernel.org/all/582f41c0-2742-4400-9c81-0d46bf4e8314@gmail.com/
> >
> > While at it, move the sanity check for page pool to on free.
> >
> > Suggested-by: David Hildenbrand <david@...hat.com>
> > Co-developed-by: Pavel Begunkov <asml.silence@...il.com>
> > Signed-off-by: Pavel Begunkov <asml.silence@...il.com>
> > Signed-off-by: Byungchul Park <byungchul@...com>
> > Acked-by: David Hildenbrand <david@...hat.com>
> > Acked-by: Zi Yan <ziy@...dia.com>
> > Acked-by: Mina Almasry <almasrymina@...gle.com>
> 
> Acked-by: Toke Høiland-Jørgensen <toke@...hat.com>
> 
> IIUC, this will allow us to move the PP-specific fields out of struct
> page entirely at some point, right? What are the steps needed to get to
> that point after this?

Yes, it'd be almost done once this set gets merged :-)

Will check if I can safely remove pp fields from struct page, and do it!

	Byungchul
> 
> -Toke