netdev - Re: [net-next PATCH v2 06/11] fbnic: Rename PCS IRQ to MAC IRQ as it is actually a MAC interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKgT0Uf+ykSS3ZHLrDrUB2RFpV9f3BXsFC7JFRXYqsB7ZuLEUA@mail.gmail.com>
Date: Mon, 3 Nov 2025 10:49:28 -0800
From: Alexander Duyck <alexander.duyck@...il.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: netdev@...r.kernel.org, kuba@...nel.org, kernel-team@...a.com, 
	andrew+netdev@...n.ch, hkallweit1@...il.com, pabeni@...hat.com, 
	davem@...emloft.net
Subject: Re: [net-next PATCH v2 06/11] fbnic: Rename PCS IRQ to MAC IRQ as it
 is actually a MAC interrupt

On Mon, Nov 3, 2025 at 9:48 AM Russell King (Oracle)
<linux@...linux.org.uk> wrote:
>
> On Mon, Nov 03, 2025 at 09:00:41AM -0800, Alexander Duyck wrote:
> > @@ -131,26 +131,26 @@ static irqreturn_t fbnic_pcs_msix_intr(int __always_unused irq, void *data)
> >
> >       fbn = netdev_priv(fbd->netdev);
> >
> > -     phylink_pcs_change(&fbn->phylink_pcs, false);
> > +     phylink_mac_change(fbn->phylink, false);
>
> Please don't. phylink_mac_change() is the older version from before
> phylink ended up with split PCS support. Some drivers still use it
> (because I haven't got around to sorting those out - I've got the
> mess formerly known as stmmac that I'm dealing with.)
>
> It only makes sense to tell phylink about a change in status if there
> is a PCS, because that's the only way phylink can be told of updated
> status.

Okay. I will update that. But FYI this is just a transient change as
these all get replaced with calls to phy_mac_interrupt when we add the
phydev to deal with the PMD link state tracking.