netdev - Re: [PATCH net-next 3/3] selftests: net: add YNL test framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251103160527.2813b61c@kernel.org>
Date: Mon, 3 Nov 2025 16:05:27 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org, Donald Hunter <donald.hunter@...il.com>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Jan Stancek
 <jstancek@...hat.com>, "Matthieu Baerts (NGI0)" <matttbe@...nel.org>,
 Asbjørn Sloth Tønnesen <ast@...erby.net>,
 Stanislav Fomichev <sdf@...ichev.me>, Shuah Khan <shuah@...nel.org>, Ido
 Schimmel <idosch@...dia.com>, Guillaume Nault <gnault@...hat.com>, Petr
 Machata <petrm@...dia.com>, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next 3/3] selftests: net: add YNL test framework

On Mon, 3 Nov 2025 05:12:43 +0000 Hangbin Liu wrote:
> On Fri, Oct 31, 2025 at 11:24:06AM -0700, Jakub Kicinski wrote:
> > > I just do `make install` in tools/net/ynl. Both the ynl scripts and specs are
> > > installed. So I think the specs are also tested.
> > >
> > > I didn't get here. The `ynl` calls pyynl.cli:main, that should be enough.
> > > Do you mean we should find the `cli.py` path and call it like
> > > `$source_code/tools/net/ynl/pyynl/cli.py --spec
> > > $source_code/Documentation/netlink/specs/xxx.yaml ...`?  
> > 
> > More or less. But it needs to know how to install itself when kernel
> > selftests are installed. Maybe it's not worth the complexity and we
> > should add the script under tools/net/ynl. Easier to refer from there.  
> 
> Hmm, how should we execute the script under `tools/net/ynl`? Use the cli.py
> like:
> 
> ./cli.py --spec ../../../Documentation/netlink/specs/xxx.yaml
> 
> Or use the installed name `ynl`
> 
> ynl --family xxx ...

I think under tools/net we don't have the kernel selftest infra.
This is not great because we lose the integration benefits,
but it gives us the ability to.. do whatever want..

I think relative paths would be fine? I believe that if you run cli
from its directory you can use --family and it will refer to the
in-tree specs automagically ?