netdev - 回覆: [PATCH net-next v3 1/4] dt-bindings: net: ftgmac100: Add delay properties for AST2600

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SEYPR06MB5134396D2CD9BD7EE47137F09DC4A@SEYPR06MB5134.apcprd06.prod.outlook.com>
Date: Tue, 4 Nov 2025 05:22:59 +0000
From: Jacky Chou <jacky_chou@...eedtech.com>
To: Andrew Lunn <andrew@...n.ch>
CC: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring
	<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>, Po-Yu Chuang <ratbert@...aday-tech.com>, Joel Stanley
	<joel@....id.au>, Andrew Jeffery <andrew@...econstruct.com.au>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "taoren@...a.com" <taoren@...a.com>
Subject:
 回覆: [PATCH net-next v3 1/4] dt-bindings: net: ftgmac100: Add delay properties for AST2600

> > diff --git
> > a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> > b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> > index d14410018bcf..de646e7e3bca 100644
> > --- a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> > +++ b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> > @@ -19,6 +19,12 @@ properties:
> >                - aspeed,ast2500-mac
> >                - aspeed,ast2600-mac
> 
> I don't know if it is possible, but it would be good to mark aspeed,ast2600-mac
> as deprecated.
> 
> I also think some comments would be good, explaining how
> aspeed,ast2600-mac01 and aspeed,ast2600-mac23 differ from
> aspeed,ast2600-mac, and why you should use them.
> 

Thanks for the suggestion.
We keep "aspeed,ast2600-mac" in the compatible list mainly for backward compatibility.
There are already many existing device trees and systems using this string.
Removing or deprecating it right now might break those setups.

However, I agree that adding comments to clarify the differences between "aspeed,ast2600-mac",
"aspeed,ast2600-mac01", and "aspeed,ast2600-mac23" would be helpful for new users. 

In the future, if someone submits a new DTS for an AST2600-based platform,
I think they should add the new compatible string and properly describe the TX/RX delay and 
phy-mode properties in their DTS.

Thanks,
Jacky