netdev - Re: [PATCH leds v2 00/10] Add support for offloading netdev trigger to HW + example implementation for Turris Omnia

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CA+V-a8snRfFrZeuJ7QSt==B5vWAyTpHzdNj0Jx6oz_aaozbGYQ@mail.gmail.com>
Date: Wed, 5 Nov 2025 13:32:56 +0000
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Marek Behún <kabel@...nel.org>, 
	linux-leds@...r.kernel.org, netdev@...r.kernel.org, 
	Pavel Machek <pavel@....cz>, Dan Murphy <dmurphy@...com>, Russell King <linux@...linux.org.uk>, 
	Matthias Schiffer <matthias.schiffer@...tq-group.com>, 
	Jacek Anaszewski <jacek.anaszewski@...il.com>, 
	Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Subject: Re: [PATCH leds v2 00/10] Add support for offloading netdev trigger
 to HW + example implementation for Turris Omnia

Hi Andrew,

On Fri, Oct 17, 2025 at 4:23 PM Lad, Prabhakar
<prabhakar.csengg@...il.com> wrote:
>
> Hi Andrew,
>
> On Thu, Oct 16, 2025 at 8:44 PM Andrew Lunn <andrew@...n.ch> wrote:
> >
> > > I haven't explored the current leds code tbh. Can you please point me
> > > to any PHY which uses leds if any.
> >
> > ~/linux/drivers/net/phy$ grep .led_brightness_set *
> > air_en8811h.c:static int air_led_brightness_set(struct phy_device *phydev, u8 index,
> > air_en8811h.c:  .led_brightness_set     = air_led_brightness_set,
> > as21xxx.c:static int as21xxx_led_brightness_set(struct phy_device *phydev,
> > as21xxx.c:              .led_brightness_set = as21xxx_led_brightness_set,
> > as21xxx.c:              .led_brightness_set = as21xxx_led_brightness_set,
> > as21xxx.c:              .led_brightness_set = as21xxx_led_brightness_set,
> > as21xxx.c:              .led_brightness_set = as21xxx_led_brightness_set,
> > as21xxx.c:              .led_brightness_set = as21xxx_led_brightness_set,
> > as21xxx.c:              .led_brightness_set = as21xxx_led_brightness_set,
> > as21xxx.c:              .led_brightness_set = as21xxx_led_brightness_set,
> > as21xxx.c:              .led_brightness_set = as21xxx_led_brightness_set,
> > as21xxx.c:              .led_brightness_set = as21xxx_led_brightness_set,
> > as21xxx.c:              .led_brightness_set = as21xxx_led_brightness_set,
> > bcm-phy-lib.c:int bcm_phy_led_brightness_set(struct phy_device *phydev,
> > bcm-phy-lib.c:EXPORT_SYMBOL_GPL(bcm_phy_led_brightness_set);
> > bcm-phy-lib.h:int bcm_phy_led_brightness_set(struct phy_device *phydev,
> > broadcom.c:     .led_brightness_set     = bcm_phy_led_brightness_set,
> > broadcom.c:     .led_brightness_set     = bcm_phy_led_brightness_set,
> > broadcom.c:     .led_brightness_set     = bcm_phy_led_brightness_set,
> > broadcom.c:     .led_brightness_set     = bcm_phy_led_brightness_set,
> > broadcom.c:     .led_brightness_set     = bcm_phy_led_brightness_set,
> > broadcom.c:     .led_brightness_set     = bcm_phy_led_brightness_set,
> > broadcom.c:     .led_brightness_set     = bcm_phy_led_brightness_set,
> > broadcom.c:     .led_brightness_set     = bcm_phy_led_brightness_set,
> > broadcom.c:     .led_brightness_set     = bcm_phy_led_brightness_set,
> > broadcom.c:     .led_brightness_set     = bcm_phy_led_brightness_set,
> > broadcom.c:     .led_brightness_set     = bcm_phy_led_brightness_set,
> > broadcom.c:     .led_brightness_set     = bcm_phy_led_brightness_set,
> > broadcom.c:     .led_brightness_set     = bcm_phy_led_brightness_set,
> > broadcom.c:     .led_brightness_set     = bcm_phy_led_brightness_set,
> > broadcom.c:     .led_brightness_set     = bcm_phy_led_brightness_set,
> > dp83867.c:dp83867_led_brightness_set(struct phy_device *phydev,
> > dp83867.c:              .led_brightness_set = dp83867_led_brightness_set,
> > dp83td510.c:static int dp83td510_led_brightness_set(struct phy_device *phydev, u8 index,
> > dp83td510.c:    .led_brightness_set = dp83td510_led_brightness_set,
> > intel-xway.c:static int xway_gphy_led_brightness_set(struct phy_device *phydev,
> > intel-xway.c:           .led_brightness_set = xway_gphy_led_brightness_set,
> > intel-xway.c:           .led_brightness_set = xway_gphy_led_brightness_set,
> > intel-xway.c:           .led_brightness_set = xway_gphy_led_brightness_set,
> > intel-xway.c:           .led_brightness_set = xway_gphy_led_brightness_set,
> > intel-xway.c:           .led_brightness_set = xway_gphy_led_brightness_set,
> > intel-xway.c:           .led_brightness_set = xway_gphy_led_brightness_set,
> > intel-xway.c:           .led_brightness_set = xway_gphy_led_brightness_set,
> > intel-xway.c:           .led_brightness_set = xway_gphy_led_brightness_set,
> > intel-xway.c:           .led_brightness_set = xway_gphy_led_brightness_set,
> > intel-xway.c:           .led_brightness_set = xway_gphy_led_brightness_set,
> > marvell.c:static int m88e1318_led_brightness_set(struct phy_device *phydev,
> > marvell.c:              .led_brightness_set = m88e1318_led_brightness_set,
> > marvell.c:              .led_brightness_set = m88e1318_led_brightness_set,
> > marvell.c:              .led_brightness_set = m88e1318_led_brightness_set,
> > marvell.c:              .led_brightness_set = m88e1318_led_brightness_set,
> > marvell.c:              .led_brightness_set = m88e1318_led_brightness_set,
> > mxl-86110.c:static int mxl86110_led_brightness_set(struct phy_device *phydev,
> > mxl-86110.c:            .led_brightness_set     = mxl86110_led_brightness_set,
> > mxl-86110.c:            .led_brightness_set     = mxl86110_led_brightness_set,
> > mxl-gpy.c:static int gpy_led_brightness_set(struct phy_device *phydev,
> > mxl-gpy.c:              .led_brightness_set = gpy_led_brightness_set,
> > mxl-gpy.c:              .led_brightness_set = gpy_led_brightness_set,
> > mxl-gpy.c:              .led_brightness_set = gpy_led_brightness_set,
> > mxl-gpy.c:              .led_brightness_set = gpy_led_brightness_set,
> > mxl-gpy.c:              .led_brightness_set = gpy_led_brightness_set,
> > mxl-gpy.c:              .led_brightness_set = gpy_led_brightness_set,
> > mxl-gpy.c:              .led_brightness_set = gpy_led_brightness_set,
> > mxl-gpy.c:              .led_brightness_set = gpy_led_brightness_set,
> > mxl-gpy.c:              .led_brightness_set = gpy_led_brightness_set,
> >
Sorry for the delayed response.

I started investigating adding PHY leds. In page 53 section "4.2.27
LED Behavior" [0] we have an option for LED0/1 combine feature
disable. For this is it OK to add a new DT property?

[0] https://ww1.microchip.com/downloads/aemDocuments/documents/UNG/ProductDocuments/DataSheets/VMDS-10513_VSC8541-02_VSC8541-05_Datasheet.pdf

Cheers,
Prabhakar