netdev - Re: [PATCH leds v2 00/10] Add support for offloading netdev trigger to HW + example implementation for Turris Omnia

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7454a3f-fac8-4789-a3ef-baf341aea8f0@lunn.ch>
Date: Wed, 5 Nov 2025 16:48:58 +0100
From: Andrew Lunn <andrew@...n.ch>
To: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
Cc: Marek Behún <kabel@...nel.org>,
	linux-leds@...r.kernel.org, netdev@...r.kernel.org,
	Pavel Machek <pavel@....cz>, Dan Murphy <dmurphy@...com>,
	Russell King <linux@...linux.org.uk>,
	Matthias Schiffer <matthias.schiffer@...tq-group.com>,
	Jacek Anaszewski <jacek.anaszewski@...il.com>,
	Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Subject: Re: [PATCH leds v2 00/10] Add support for offloading netdev trigger
 to HW + example implementation for Turris Omnia

> Sorry for the delayed response.
> 
> I started investigating adding PHY leds. In page 53 section "4.2.27
> LED Behavior" [0] we have an option for LED0/1 combine feature
> disable. For this is it OK to add a new DT property?

Why do you need a new property?

You just need to set this bit depending on what has been selected via
/sys/class/led.

And if the user asks for a mode which the hardware does not supported,
the core will fall back to use on/off and blink the LED itself.

PHY LEDs are the wild west. Every vendor has its own idea what is
important, and adds features which other vendors don't have. But that
does not mean we need to support all the features in Linux. So the
core has a reasonable set of features which we expect most PHYs can
support. I don't want to add more features unless you have a big
business case it is needed, and other PHY also have the same feature.

     Andrew