netdev - Re: [PATCH v3] usb: rtl8150: Initialize buffers to fix KMSAN uninit-value in rtl8150

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5565fd2-358a-4e76-a449-f6fd97e6dc09@lunn.ch>
Date: Wed, 5 Nov 2025 21:26:05 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Dharanitharan R <dharanitharan725@...il.com>
Cc: netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	gregkh@...uxfoundation.org, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	syzbot+b4d5d8faea6996fd55e3@...kaller.appspotmail.com
Subject: Re: [PATCH v3] usb: rtl8150: Initialize buffers to fix KMSAN
 uninit-value in rtl8150_open

On Wed, Nov 05, 2025 at 07:56:26PM +0000, Dharanitharan R wrote:
> KMSAN reported an uninitialized value use in rtl8150_open().
> Initialize rx_skb->data and intr_buff before submitting URBs to
> ensure memory is in a defined state.

> @@ -769,8 +766,7 @@ static int rtl8150_open(struct net_device *netdev)
>  	enable_net_traffic(dev);
>  	set_carrier(netdev);
>  	netif_start_queue(netdev);
> -
> -	return res;
> +	return 0;
>  }

While i agree that res is guaranteed to by 0, this change has nothing
to do with fixing a KMSAN report. Please make it a separate patch in a
patch series. A patch should do one thing, and the commit message
should explain the "why?" of the change.

Please also take a read of:

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

The Subject line should indicate which tree this is for.

	Andrew