netdev - Re: [PATCH v3] usb: rtl8150: Initialize buffers to fix KMSAN uninit-value in rtl8150

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <11301ae7-ac18-4a2f-9728-28cf1ba1afdd@lunn.ch>
Date: Wed, 5 Nov 2025 21:37:06 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Dharanitharan R <dharanitharan725@...il.com>
Cc: netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	gregkh@...uxfoundation.org, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	syzbot+b4d5d8faea6996fd55e3@...kaller.appspotmail.com
Subject: Re: [PATCH v3] usb: rtl8150: Initialize buffers to fix KMSAN
 uninit-value in rtl8150_open

> -	usb_fill_bulk_urb(dev->rx_urb, dev->udev, usb_rcvbulkpipe(dev->udev, 1),
> -		      dev->rx_skb->data, RTL8150_MTU, read_bulk_callback, dev);
> -	if ((res = usb_submit_urb(dev->rx_urb, GFP_KERNEL))) {
> -		if (res == -ENODEV)
> -			netif_device_detach(dev->netdev);
> +	usb_fill_bulk_urb(dev->rx_urb, dev->udev,
> +			  usb_rcvbulkpipe(dev->udev, 1),
> +			  dev->rx_skb->data, RTL8150_MTU,
> +			  read_bulk_callback, dev);

If im reading this correctly, the usb_fill_bulk_urb() is identical,
you have just changed the wrapping. So this again has nothing to do
with the issue you are trying to fix. Changes like this make it harder
to see the real change which fixes the problem. And at the moment, i
don't see the actual fix.

If you want to make changes like this, please do so in a patch of its
own which only changes the wrapping, nothing else. That is then easy
to review.

Lots of small changes, which hopefully are obviously correct, with
good commit messages please.

    Andrew

---
pw-bot: cr