netdev - Re: [PATCH net-next 2/3] net: phy: realtek: eliminate has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea476549-14e1-4208-8b5c-6659eafda988@lunn.ch>
Date: Thu, 6 Nov 2025 14:52:06 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: netdev@...r.kernel.org, Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Marek Vasut <marex@...x.de>, Wei Fang <wei.fang@....com>,
	Clark Wang <xiaoning.wang@....com>
Subject: Re: [PATCH net-next 2/3] net: phy: realtek: eliminate has_phycr2
 variable

On Thu, Nov 06, 2025 at 01:10:02PM +0200, Vladimir Oltean wrote:
> This variable is assigned in rtl821x_probe() and used in
> rtl8211f_config_init(), which is more complex than it needs to be.
> Simply testing the same condition from rtl821x_probe() in
> rtl8211f_config_init() yields the same result (the PHY driver ID is a
> runtime invariant), but with one temporary variable less.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew