netdev - Re: [PATCH net-next 1/3] net: phy: realtek: eliminate priv->phycr2 variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <07183d23-c766-4ab5-962a-76ed4f5b99f0@lunn.ch>
Date: Thu, 6 Nov 2025 14:51:12 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: netdev@...r.kernel.org, Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Marek Vasut <marex@...x.de>, Wei Fang <wei.fang@....com>,
	Clark Wang <xiaoning.wang@....com>
Subject: Re: [PATCH net-next 1/3] net: phy: realtek: eliminate priv->phycr2
 variable

> +static int rtl8211f_disable_clk_out(struct phy_device *phydev)
> +{
> +	struct rtl821x_priv *priv = phydev->priv;
> +
> +	/* The value is preserved if the device tree property is absent */
> +	if (!priv->disable_clk_out)
> +		return 0;

The name rtl8211f_disable_clk_out() suggests that it is going to
disable the clock output. In fact it is conditional, and might not
actually do anything. Maybe move the condition outside? Or maybe
rename it to rtl8211f_config_clk_out()?

	Andrew