netdev - Re: [PATCH net-next 1/3] net: phy: realtek: eliminate priv->phycr2 variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251106144703.wroevzsoyvr7urzf@skbuf>
Date: Thu, 6 Nov 2025 16:47:03 +0200
From: Vladimir Oltean <vladimir.oltean@....com>
To: Andrew Lunn <andrew@...n.ch>
Cc: netdev@...r.kernel.org, Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Marek Vasut <marex@...x.de>, Wei Fang <wei.fang@....com>,
	Clark Wang <xiaoning.wang@....com>
Subject: Re: [PATCH net-next 1/3] net: phy: realtek: eliminate priv->phycr2
 variable

On Thu, Nov 06, 2025 at 02:51:12PM +0100, Andrew Lunn wrote:
> > +static int rtl8211f_disable_clk_out(struct phy_device *phydev)
> > +{
> > +	struct rtl821x_priv *priv = phydev->priv;
> > +
> > +	/* The value is preserved if the device tree property is absent */
> > +	if (!priv->disable_clk_out)
> > +		return 0;
> 
> The name rtl8211f_disable_clk_out() suggests that it is going to
> disable the clock output. In fact it is conditional, and might not
> actually do anything. Maybe move the condition outside? Or maybe
> rename it to rtl8211f_config_clk_out()?
> 
> 	Andrew

It was born out of a desire to keep the main control flow simpler.
Among the two alternatives, I would prefer to rename this function to
rtl8211f_config_clk_out().

Thanks for the review.

pw-bot: cr