netdev - Re: [PATCH v2 net-next 1/6] net: phy: realtek: create rtl8211f_config_rgmii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02ad7418-7043-4968-b34a-6fa9142e85ea@lunn.ch>
Date: Fri, 7 Nov 2025 14:27:04 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: netdev@...r.kernel.org, Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Marek Vasut <marex@...x.de>, Wei Fang <wei.fang@....com>,
	Clark Wang <xiaoning.wang@....com>
Subject: Re: [PATCH v2 net-next 1/6] net: phy: realtek: create
 rtl8211f_config_rgmii_delay()

On Fri, Nov 07, 2025 at 01:08:12PM +0200, Vladimir Oltean wrote:
> The control flow in rtl8211f_config_init() has some pitfalls which were
> probably unintended. Specifically it has an early return:
> 
> 	switch (phydev->interface) {
> 	...
> 	default: /* the rest of the modes imply leaving delay as is. */
> 		return 0;
> 	}
> 
> which exits the entire config_init() function. This means it also skips
> doing things such as disabling CLKOUT or disabling PHY-mode EEE.
> 
> For the RTL8211FS, which uses PHY_INTERFACE_MODE_SGMII, this might be a
> problem. However, I don't know that it is, so there is no Fixes: tag.
> The issue was observed through code inspection.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Pulling this out into a helper makes sense.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew