netdev - Re: [PATCH v2 net-next 2/6] net: phy: realtek: eliminate priv->phycr2 variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b57e68b-074d-4522-a9bd-6df513cb0286@lunn.ch>
Date: Fri, 7 Nov 2025 14:27:53 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: netdev@...r.kernel.org, Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Marek Vasut <marex@...x.de>, Wei Fang <wei.fang@....com>,
	Clark Wang <xiaoning.wang@....com>
Subject: Re: [PATCH v2 net-next 2/6] net: phy: realtek: eliminate
 priv->phycr2 variable

On Fri, Nov 07, 2025 at 01:08:13PM +0200, Vladimir Oltean wrote:
> The RTL8211F(D)(I)-VD-CG PHY also has support for disabling the CLKOUT,
> and we'd like to introduce the "realtek,clkout-disable" property for
> that.
> 
> But it isn't done through the PHYCR2 register, and it becomes awkward to
> have the driver pretend that it is. So just replace the machine-level
> "u16 phycr2" variable with a logical "bool disable_clk_out", which
> scales better to the other PHY as well.
> 
> The change is a complete functional equivalent. Before, if the device
> tree property was absent, priv->phycr2 would contain the RTL8211F_CLKOUT_EN
> bit as read from hardware. Now, we don't save priv->phycr2, but we just
> don't call phy_modify_paged() on it. Also, we can simply call
> phy_modify_paged() with the "set" argument to 0.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---
> v1->v2: rename rtl8211f_disable_clk_out() to rtl8211f_config_clk_out()

Thanks

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew