netdev - RE: [Intel-wired-lan] [PATCH net-next] ice: fix comment typo and correct module format string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR11MB5089BBCB0C7AFDF922167607D6C0A@CO1PR11MB5089.namprd11.prod.outlook.com>
Date: Sat, 8 Nov 2025 00:18:35 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>, Alok Tiwari
	<alok.a.tiwari@...cle.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "Lobakin, Aleksander"
	<aleksander.lobakin@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "kuba@...nel.org" <kuba@...nel.org>,
	"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC: "alok.a.tiwarilinux@...il.com" <alok.a.tiwarilinux@...il.com>
Subject: RE: [Intel-wired-lan] [PATCH net-next] ice: fix comment typo and
 correct module format string



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Loktionov, Aleksandr
> Sent: Friday, November 7, 2025 5:16 AM
> To: Alok Tiwari <alok.a.tiwari@...cle.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; Lobakin, Aleksander
> <aleksander.lobakin@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; andrew+netdev@...n.ch; kuba@...nel.org;
> davem@...emloft.net; edumazet@...gle.com; pabeni@...hat.com; intel-
> wired-lan@...ts.osuosl.org; netdev@...r.kernel.org
> Cc: alok.a.tiwarilinux@...il.com
> Subject: Re: [Intel-wired-lan] [PATCH net-next] ice: fix comment typo and correct
> module format string
> 
> 
> 
> > -----Original Message-----
> > From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> > Of Alok Tiwari
> > Sent: Friday, November 7, 2025 1:40 PM
> > To: Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>; Lobakin,
> > Aleksander <aleksander.lobakin@...el.com>; Nguyen, Anthony L
> > <anthony.l.nguyen@...el.com>; andrew+netdev@...n.ch; kuba@...nel.org;
> > davem@...emloft.net; edumazet@...gle.com; pabeni@...hat.com; intel-
> > wired-lan@...ts.osuosl.org; netdev@...r.kernel.org
> > Cc: alok.a.tiwarilinux@...il.com; alok.a.tiwari@...cle.com
> > Subject: [Intel-wired-lan] [PATCH net-next] ice: fix comment typo and
> > correct module format string
> >
> > - Fix a typo in the ice_fdir_has_frag() kernel-doc comment ("is" ->
> > "if")
> >
> > - Correct the NVM erase error message format string from "0x02%x" to
> >   "0x%02x" so the module value is printed correctly.
> >
> > Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
> > ---
> >  drivers/net/ethernet/intel/ice/ice_fdir.c      | 2 +-
> >  drivers/net/ethernet/intel/ice/ice_fw_update.c | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/intel/ice/ice_fdir.c
> > b/drivers/net/ethernet/intel/ice/ice_fdir.c
> > index 26b357c0ae15..ec73088ef37b 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_fdir.c
> > +++ b/drivers/net/ethernet/intel/ice/ice_fdir.c
> > @@ -1121,7 +1121,7 @@ ice_fdir_get_gen_prgm_pkt(struct ice_hw *hw,
> > struct ice_fdir_fltr *input,
> >   * ice_fdir_has_frag - does flow type have 2 ptypes
> >   * @flow: flow ptype
> >   *
> > - * returns true is there is a fragment packet for this ptype
> > + * returns true if there is a fragment packet for this ptype

I know this is a simple typo fix and am fine accepting the patch as-is, but you could also clean this kdoc error up by using "Returns:" here to avoid a warning from the kernel-doc script.

Thanks,
Jake