netdev - Re: [Intel-wired-lan] [PATCH net-next] ice: fix comment typo and correct module format string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a9fa920-105b-4707-9e5a-c92e9d7fe49b@molgen.mpg.de>
Date: Sun, 9 Nov 2025 15:41:09 +0100
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Alok Tiwari <alok.a.tiwari@...cle.com>
Cc: przemyslaw.kitszel@...el.com, aleksander.lobakin@...el.com,
 anthony.l.nguyen@...el.com, andrew+netdev@...n.ch, kuba@...nel.org,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
 alok.a.tiwarilinux@...il.com
Subject: Re: [Intel-wired-lan] [PATCH net-next] ice: fix comment typo and
 correct module format string

Dear Alok,


Thank you for your patch.

Am 07.11.25 um 13:39 schrieb Alok Tiwari:
> - Fix a typo in the ice_fdir_has_frag() kernel-doc comment ("is" -> "if")
> 
> - Correct the NVM erase error message format string from "0x02%x" to
>    "0x%02x" so the module value is printed correctly.

Listing changes in a commit message is a good indicator to split it up, 
even it’s formal changes.

> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
> ---
>   drivers/net/ethernet/intel/ice/ice_fdir.c      | 2 +-
>   drivers/net/ethernet/intel/ice/ice_fw_update.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_fdir.c b/drivers/net/ethernet/intel/ice/ice_fdir.c
> index 26b357c0ae15..ec73088ef37b 100644
> --- a/drivers/net/ethernet/intel/ice/ice_fdir.c
> +++ b/drivers/net/ethernet/intel/ice/ice_fdir.c
> @@ -1121,7 +1121,7 @@ ice_fdir_get_gen_prgm_pkt(struct ice_hw *hw, struct ice_fdir_fltr *input,
>    * ice_fdir_has_frag - does flow type have 2 ptypes
>    * @flow: flow ptype
>    *
> - * returns true is there is a fragment packet for this ptype
> + * returns true if there is a fragment packet for this ptype
>    */
>   bool ice_fdir_has_frag(enum ice_fltr_ptype flow)
>   {
> diff --git a/drivers/net/ethernet/intel/ice/ice_fw_update.c b/drivers/net/ethernet/intel/ice/ice_fw_update.c
> index d86db081579f..973a13d3d92a 100644
> --- a/drivers/net/ethernet/intel/ice/ice_fw_update.c
> +++ b/drivers/net/ethernet/intel/ice/ice_fw_update.c
> @@ -534,7 +534,7 @@ ice_erase_nvm_module(struct ice_pf *pf, u16 module, const char *component,
>   	}
>   
>   	if (completion_retval) {
> -		dev_err(dev, "Firmware failed to erase %s (module 0x02%x), aq_err %s\n",
> +		dev_err(dev, "Firmware failed to erase %s (module 0x%02x), aq_err %s\n",
>   			component, module,
>   			libie_aq_str((enum libie_aq_err)completion_retval));
>   		NL_SET_ERR_MSG_MOD(extack, "Firmware failed to erase flash");

Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>


Kind regards,

Paul