netdev - Re: [External] : Re: [Intel-wired-lan] [PATCH net-next] ice: fix comment typo and correct module format string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c86e71bd-0e67-4ea0-a62f-a8c729351649@oracle.com>
Date: Sun, 9 Nov 2025 21:02:30 +0530
From: ALOK TIWARI <alok.a.tiwari@...cle.com>
To: Paul Menzel <pmenzel@...gen.mpg.de>
Cc: przemyslaw.kitszel@...el.com, aleksander.lobakin@...el.com,
        anthony.l.nguyen@...el.com, andrew+netdev@...n.ch, kuba@...nel.org,
        davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
        alok.a.tiwarilinux@...il.com
Subject: Re: [External] : Re: [Intel-wired-lan] [PATCH net-next] ice: fix
 comment typo and correct module format string



On 11/9/2025 8:11 PM, Paul Menzel wrote:
> Dear Alok,
> 
> 
> Thank you for your patch.
> 
> Am 07.11.25 um 13:39 schrieb Alok Tiwari:
>> - Fix a typo in the ice_fdir_has_frag() kernel-doc comment ("is" -> "if")
>>
>> - Correct the NVM erase error message format string from "0x02%x" to
>>    "0x%02x" so the module value is printed correctly.
> 
> Listing changes in a commit message is a good indicator to split it up, 
> even it’s formal changes.
> 

Thanks You, Paul
I will ensure that future submissions split each logical change
into separate patches, including formal or cosmetic fixes.

>> - * returns true is there is a fragment packet for this ptype
>> + * returns true if there is a fragment packet for this ptype
>>    */
>>   bool ice_fdir_has_frag(enum ice_fltr_ptype flow)
>>   {
>> diff --git a/drivers/net/ethernet/intel/ice/ice_fw_update.c b/drivers/ 
>> net/ethernet/intel/ice/ice_fw_update.c
>> index d86db081579f..973a13d3d92a 100644
>> --- a/drivers/net/ethernet/intel/ice/ice_fw_update.c
>> +++ b/drivers/net/ethernet/intel/ice/ice_fw_update.c
>> @@ -534,7 +534,7 @@ ice_erase_nvm_module(struct ice_pf *pf, u16 
>> module, const char *component,
>>       }
>>       if (completion_retval) {
>> -        dev_err(dev, "Firmware failed to erase %s (module 0x02%x), 
>> aq_err %s\n",
>> +        dev_err(dev, "Firmware failed to erase %s (module 0x%02x), 
>> aq_err %s\n",
>>               component, module,
>>               libie_aq_str((enum libie_aq_err)completion_retval));
>>           NL_SET_ERR_MSG_MOD(extack, "Firmware failed to erase flash");
> 
> Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>
> 
> 
> Kind regards,
> 
> Paul


Thanks,
Alok