netdev - Re: [PATCH net v2] strparser: Fix signed/unsigned mismatch bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <176256900601.1226704.4652843459879323361.git-patchwork-notify@kernel.org>
Date: Sat, 08 Nov 2025 02:30:06 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Nate Karstens <nate.karstens@...min.com>
Cc: netdev@...r.kernel.org, nate.karstens@...il.com, tom@...ntonium.net,
 sd@...asysnail.net, jacob.e.keller@...el.com, stable@...r.kernel.org,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 horms@...nel.org, martin.lau@...nel.org, jakub@...udflare.com, mrpre@....com,
 linux@...blig.org, tom@...bertland.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2] strparser: Fix signed/unsigned mismatch bug

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Thu, 6 Nov 2025 16:28:33 -0600 you wrote:
> The `len` member of the sk_buff is an unsigned int. This is cast to
> `ssize_t` (a signed type) for the first sk_buff in the comparison,
> but not the second sk_buff. On 32-bit systems, this can result in
> an integer underflow for certain values because unsigned arithmetic
> is being used.
> 
> This appears to be an oversight: if the intention was to use unsigned
> arithmetic, then the first cast would have been omitted. The change
> ensures both len values are cast to `ssize_t`.
> 
> [...]

Here is the summary with links:
  - [net,v2] strparser: Fix signed/unsigned mismatch bug
    https://git.kernel.org/netdev/net/c/4da4e4bde1c4

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html