netdev - Re: [PATCH net-next v2 1/2] bnx2x: convert to use ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251107184102.65b0f765@kernel.org>
Date: Fri, 7 Nov 2025 18:41:02 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc: Manish Chopra <manishc@...vell.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Richard
 Cochran <richardcochran@...il.com>, Simon Horman <horms@...nel.org>, Jacob
 Keller <jacob.e.keller@...el.com>, Kory Maincent
 <kory.maincent@...tlin.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 1/2] bnx2x: convert to use ndo_hwtstamp
 callbacks

On Thu,  6 Nov 2025 21:37:16 +0000 Vadim Fedorenko wrote:
> +	switch (config->tx_type) {
> +	case HWTSTAMP_TX_ONESTEP_SYNC:
> +	case HWTSTAMP_TX_ONESTEP_P2P:
> +		NL_SET_ERR_MSG_MOD(extack,
> +				   "One-step timestamping is not supported");
> +		return -ERANGE;
> +	default:
> +		break;
> +	}

This is the wrong way around, if someone adds a new value unsupported
by the driver it will pass. We should be listing the supported types
and

	default:
		...ERR_MSG..
		return -ERANGE;
	}
-- 
pw-bot: cr