netdev - Re: [PATCH net-next 2/2] net: phy: TI PHYs use phy_get_features_no

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aRRFDUewyw9x7teC@pengutronix.de>
Date: Wed, 12 Nov 2025 09:27:57 +0100
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Emanuele Ghidoli <ghidoliemanuele@...il.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Fabio Estevam <festevam@...il.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	netdev@...r.kernel.org, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 2/2] net: phy: TI PHYs use
 phy_get_features_no_eee()

On Tue, Nov 11, 2025 at 11:38:43AM +0000, Russell King (Oracle) wrote:
> As TI Gigabit PHYs do not support EEE, use the newly introduced
> phy_get_features_no_eee() to read the features but mark EEE as
> disabled.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> ---
>  drivers/net/phy/dp83822.c   | 3 +++
>  drivers/net/phy/dp83867.c   | 1 +
>  drivers/net/phy/dp83869.c   | 1 +
>  drivers/net/phy/dp83tc811.c | 1 +
>  4 files changed, 6 insertions(+)
> 
> diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c
> index 33db21251f2e..20caf9a5faa7 100644
> --- a/drivers/net/phy/dp83822.c
> +++ b/drivers/net/phy/dp83822.c
> @@ -1160,6 +1160,7 @@ static int dp83822_led_hw_control_get(struct phy_device *phydev, u8 index,
>  		.name		= (_name),			\
>  		/* PHY_BASIC_FEATURES */			\
>  		.probe          = dp83822_probe,		\
> +		.get_features	= phy_get_features_no_eee,	\
>  		.soft_reset	= dp83822_phy_reset,		\
>  		.config_init	= dp83822_config_init,		\
>  		.read_status	= dp83822_read_status,		\
> @@ -1180,6 +1181,7 @@ static int dp83822_led_hw_control_get(struct phy_device *phydev, u8 index,
>  		.name		= (_name),			\
>  		/* PHY_BASIC_FEATURES */			\
>  		.probe          = dp8382x_probe,		\
> +		.get_features	= phy_get_features_no_eee,	\
>  		.soft_reset	= dp83822_phy_reset,		\
>  		.config_init	= dp83825_config_init,		\
>  		.get_wol = dp83822_get_wol,			\
> @@ -1196,6 +1198,7 @@ static int dp83822_led_hw_control_get(struct phy_device *phydev, u8 index,
>  		.name		= (_name),			\
>  		/* PHY_BASIC_FEATURES */			\
>  		.probe          = dp83826_probe,		\
> +		.get_features	= phy_get_features_no_eee,	\
>  		.soft_reset	= dp83822_phy_reset,		\
>  		.config_init	= dp83826_config_init,		\
>  		.get_wol = dp83822_get_wol,			\

The DP83822/25/26 are all 100 Mbit variants. They all officially claim
EEE support. Maybe it is too early to give up here?

> diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
> index 36a0c1b7f59c..da055ff861be 100644
> --- a/drivers/net/phy/dp83867.c
> +++ b/drivers/net/phy/dp83867.c
> @@ -1124,6 +1124,7 @@ static struct phy_driver dp83867_driver[] = {
>  		/* PHY_GBIT_FEATURES */
>  
>  		.probe          = dp83867_probe,
> +		.get_features	= phy_get_features_no_eee,
>  		.config_init	= dp83867_config_init,
>  		.soft_reset	= dp83867_phy_reset,

ACK

> diff --git a/drivers/net/phy/dp83869.c b/drivers/net/phy/dp83869.c
> index 1f381d7b13ff..4400654b0f72 100644
> --- a/drivers/net/phy/dp83869.c
> +++ b/drivers/net/phy/dp83869.c
> @@ -906,6 +906,7 @@ static int dp83869_phy_reset(struct phy_device *phydev)
>  	PHY_ID_MATCH_MODEL(_id),				\
>  	.name		= (_name),				\
>  	.probe          = dp83869_probe,			\
> +	.get_features	= phy_get_features_no_eee,		\
>  	.config_init	= dp83869_config_init,			\
>  	.soft_reset	= dp83869_phy_reset,			\
>  	.config_intr	= dp83869_config_intr,			\

ACK

> diff --git a/drivers/net/phy/dp83tc811.c b/drivers/net/phy/dp83tc811.c
> index e480c2a07450..92c5f3cfee9e 100644
> --- a/drivers/net/phy/dp83tc811.c
> +++ b/drivers/net/phy/dp83tc811.c
> @@ -390,6 +390,7 @@ static struct phy_driver dp83811_driver[] = {
>  		.phy_id_mask = 0xfffffff0,
>  		.name = "TI DP83TC811",
>  		/* PHY_BASIC_FEATURES */
> +		.get_features = phy_get_features_no_eee,
>  		.config_init = dp83811_config_init,
>  		.config_aneg = dp83811_config_aneg,
>  		.soft_reset = dp83811_phy_reset,

Not sure about this one. It is 100BaseT1 without autoneg support.

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |