netdev - Re: [PATCH net-next 2/2] net: phy: TI PHYs use phy_get_features_no

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aRRGbAR26GuyKKZl@shell.armlinux.org.uk>
Date: Wed, 12 Nov 2025 08:33:48 +0000
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Emanuele Ghidoli <ghidoliemanuele@...il.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Fabio Estevam <festevam@...il.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	netdev@...r.kernel.org, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 2/2] net: phy: TI PHYs use
 phy_get_features_no_eee()

On Wed, Nov 12, 2025 at 09:27:57AM +0100, Oleksij Rempel wrote:
> On Tue, Nov 11, 2025 at 11:38:43AM +0000, Russell King (Oracle) wrote:
> > As TI Gigabit PHYs do not support EEE, use the newly introduced
> > phy_get_features_no_eee() to read the features but mark EEE as
> > disabled.
> > 
> > Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
...
> > @@ -1196,6 +1198,7 @@ static int dp83822_led_hw_control_get(struct phy_device *phydev, u8 index,
> >  		.name		= (_name),			\
> >  		/* PHY_BASIC_FEATURES */			\
> >  		.probe          = dp83826_probe,		\
> > +		.get_features	= phy_get_features_no_eee,	\
> >  		.soft_reset	= dp83822_phy_reset,		\
> >  		.config_init	= dp83826_config_init,		\
> >  		.get_wol = dp83822_get_wol,			\
> 
> The DP83822/25/26 are all 100 Mbit variants. They all officially claim
> EEE support. Maybe it is too early to give up here?

This is going to be horrid to guarantee getting the correct entry
in the patch - I *absolutely* hate this driver struct array. Please
provide a diff to be squashed into the patch.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!