netdev - [PATCH] net: dp83822/dp83tc811: do not blacklist EEE for now

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251112135935.266945-1-o.rempel@pengutronix.de>
Date: Wed, 12 Nov 2025 14:59:35 +0100
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: linux@...linux.org.uk,
	netdev@...r.kernel.org
Cc: Oleksij Rempel <o.rempel@...gutronix.de>
Subject: [PATCH] net: dp83822/dp83tc811: do not blacklist EEE for now

dp83822 driver is supporting DP83822/25/26 PHYs, which are
all 100Mbit variants. TI support forum says - only 1Gbit variants are
broken.

dp83tc811 driver is supporting 1000BaseT1 SPE variant, which do not has
autoneg support towards MDI.

Note: dp83tc811 wires phydev->autoneg to control SGMII autoneg, which
can't be proper decision. But it is a different issue.

Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
---
 drivers/net/phy/dp83822.c   | 3 ---
 drivers/net/phy/dp83tc811.c | 1 -
 2 files changed, 4 deletions(-)

diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c
index 20caf9a5faa7..33db21251f2e 100644
--- a/drivers/net/phy/dp83822.c
+++ b/drivers/net/phy/dp83822.c
@@ -1160,7 +1160,6 @@ static int dp83822_led_hw_control_get(struct phy_device *phydev, u8 index,
 		.name		= (_name),			\
 		/* PHY_BASIC_FEATURES */			\
 		.probe          = dp83822_probe,		\
-		.get_features	= phy_get_features_no_eee,	\
 		.soft_reset	= dp83822_phy_reset,		\
 		.config_init	= dp83822_config_init,		\
 		.read_status	= dp83822_read_status,		\
@@ -1181,7 +1180,6 @@ static int dp83822_led_hw_control_get(struct phy_device *phydev, u8 index,
 		.name		= (_name),			\
 		/* PHY_BASIC_FEATURES */			\
 		.probe          = dp8382x_probe,		\
-		.get_features	= phy_get_features_no_eee,	\
 		.soft_reset	= dp83822_phy_reset,		\
 		.config_init	= dp83825_config_init,		\
 		.get_wol = dp83822_get_wol,			\
@@ -1198,7 +1196,6 @@ static int dp83822_led_hw_control_get(struct phy_device *phydev, u8 index,
 		.name		= (_name),			\
 		/* PHY_BASIC_FEATURES */			\
 		.probe          = dp83826_probe,		\
-		.get_features	= phy_get_features_no_eee,	\
 		.soft_reset	= dp83822_phy_reset,		\
 		.config_init	= dp83826_config_init,		\
 		.get_wol = dp83822_get_wol,			\
diff --git a/drivers/net/phy/dp83tc811.c b/drivers/net/phy/dp83tc811.c
index 92c5f3cfee9e..e480c2a07450 100644
--- a/drivers/net/phy/dp83tc811.c
+++ b/drivers/net/phy/dp83tc811.c
@@ -390,7 +390,6 @@ static struct phy_driver dp83811_driver[] = {
 		.phy_id_mask = 0xfffffff0,
 		.name = "TI DP83TC811",
 		/* PHY_BASIC_FEATURES */
-		.get_features = phy_get_features_no_eee,
 		.config_init = dp83811_config_init,
 		.config_aneg = dp83811_config_aneg,
 		.soft_reset = dp83811_phy_reset,
-- 
2.47.3