netdev - Re: [PATCH net 1/2] hsr: Fix supervision frame sending on HSRv0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251112100343.9biqchIs@linutronix.de>
Date: Wed, 12 Nov 2025 11:03:43 +0100
From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To: Felix Maurer <fmaurer@...hat.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
	liuhangbin@...il.com, m-karicheri2@...com, arvid.brodin@...en.se
Subject: Re: [PATCH net 1/2] hsr: Fix supervision frame sending on HSRv0

On 2025-11-11 17:29:32 [+0100], Felix Maurer wrote:
> On HSRv0, no supervision frames were sent. The supervison frames were
> generated successfully, but failed the check for a sufficiently long mac
> header, i.e., at least sizeof(struct hsr_ethhdr), in hsr_fill_frame_info()
> because the mac header only contained the ethernet header.
> 
> Fix this by including the HSR header in the mac header when generating HSR
> supervision frames. Note that the mac header now also includes the TLV
> fields. This matches how we set the headers on rx and also the size of
> struct hsrv0_ethhdr_sp.
> 
> Reported-by: Hangbin Liu <liuhangbin@...il.com>
> Closes: https://lore.kernel.org/netdev/aMONxDXkzBZZRfE5@fedora/
> Fixes: 9cfb5e7f0ded ("net: hsr: fix hsr_init_sk() vs network/transport headers.")
> Signed-off-by: Felix Maurer <fmaurer@...hat.com>

Reviewed-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Tested-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

Sebastian