netdev - Re: [PATCH net 2/2] hsr: Follow standard for HSRv0 supervision frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251112102405.8xxcDBuT@linutronix.de>
Date: Wed, 12 Nov 2025 11:24:05 +0100
From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To: Felix Maurer <fmaurer@...hat.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
	liuhangbin@...il.com, m-karicheri2@...com, arvid.brodin@...en.se
Subject: Re: [PATCH net 2/2] hsr: Follow standard for HSRv0 supervision frames

On 2025-11-11 17:29:33 [+0100], Felix Maurer wrote:
> For HSRv0, the path_id has the following meaning:
> - 0000: PRP supervision frame
> - 0001-1001: HSR ring identifier
> - 1010-1011: Frames from PRP network (A/B, with RedBoxes)
> - 1111: HSR supervision frame

Where do you have this from?
I have here IEC 62439-3:2021 (Edition 4.0 2021-12).
>From the 4 bits of path_id, the three most significant bits are NetId
with 0 for HSR and 1 to 6 for the PTP network and 7 reserved.
The list significant bit for PRP indicates Redbox A/B while for HSR it
indicates port A/B.

You say HSRv0 while I don't see this mentioned at all. And you limit the
change to prot_version == 0. So maybe this was once and removed from the
standard.

Since this is limited to v0:
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

Sebastian