netdev - Re: [PATCH net-next 2/3] net: fix napi_consume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89i+UDX16RYo5jAKHhZ5cNstNjS9qzoogM+imUgzYMQigtQ@mail.gmail.com>
Date: Wed, 12 Nov 2025 07:32:52 -0800
From: Eric Dumazet <edumazet@...gle.com>
To: Jon Hunter <jonathanh@...dia.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuniyu@...gle.com>, Willem de Bruijn <willemb@...gle.com>, netdev@...r.kernel.org, 
	eric.dumazet@...il.com, 
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH net-next 2/3] net: fix napi_consume_skb() with alien skbs

On Wed, Nov 12, 2025 at 7:27 AM Jon Hunter <jonathanh@...dia.com> wrote:
>
>
> On 12/11/2025 14:08, Eric Dumazet wrote:
>
> ...
>
> >> I have noticed a suspend regression on one of our Tegra boards. Bisect
> >> is pointing to this commit and reverting this on top of -next fixes the
> >> issue.
> >>
> >> Out of all the Tegra boards we test only one is failing and that is the
> >> tegra124-jetson-tk1. This board uses the realtek r8169 driver ...
> >>
> >>    r8169 0000:01:00.0: enabling device (0140 -> 0143)
> >>    r8169 0000:01:00.0 eth0: RTL8168g/8111g, 00:04:4b:25:b2:0e, XID 4c0, IRQ 132
> >>    r8169 0000:01:00.0 eth0: jumbo features [frames: 9194 bytes, tx checksumming: ko]
> >>
> >> I don't see any particular crash or error, and even after resuming from
> >> suspend the link does come up ...
> >>
> >>    r8169 0000:01:00.0 enp1s0: Link is Down
> >>    tegra-xusb 70090000.usb: Firmware timestamp: 2014-09-16 02:10:07 UTC
> >>    OOM killer enabled.
> >>    Restarting tasks: Starting
> >>    Restarting tasks: Done
> >>    random: crng reseeded on system resumption
> >>    PM: suspend exit
> >>    ata1: SATA link down (SStatus 0 SControl 300)
> >>    r8169 0000:01:00.0 enp1s0: Link is Up - 1Gbps/Full - flow control rx/tx
> >>
> >> However, the board does not seem to resume fully. One thing I should
> >> point out is that for testing we always use an NFS rootfs. So this
> >> would indicate that the link comes up but networking is still having
> >> issues.
> >>
> >> Any thoughts?
> >>
> >> Jon
> >
> > Perhaps try : https://patchwork.kernel.org/project/netdevbpf/patch/20251111151235.1903659-1-edumazet@google.com/
>
>
> That does indeed fix it. Feel free to add my ...
>
> Tested-by: Jon Hunter <jonathanh@...dia.com>

Thanks for testing. Note the patch was merged already in net-next, so
we can not add your tag.

Author: Eric Dumazet <edumazet@...gle.com>
Date:   Tue Nov 11 15:12:35 2025 +0000

    net: clear skb->sk in skb_release_head_state()

    skb_release_head_state() inlines skb_orphan().

    We need to clear skb->sk otherwise we can freeze TCP flows
    on a mostly idle host, because skb_fclone_busy() would
    return true as long as the packet is not yet processed by
    skb_defer_free_flush().

    Fixes: 1fcf572211da ("net: allow skb_release_head_state() to be
called multiple times")
    Fixes: e20dfbad8aab ("net: fix napi_consume_skb() with alien skbs")
    Signed-off-by: Eric Dumazet <edumazet@...gle.com>
    Tested-by: Aditya Garg <gargaditya@...ux.microsoft.com>
    Reviewed-by: Kuniyuki Iwashima <kuniyu@...gle.com>
    Link: https://patch.msgid.link/20251111151235.1903659-1-edumazet@google.com
    Signed-off-by: Jakub Kicinski <kuba@...nel.org>