netdev - Re: [PATCH net-next 1/8] phy: add hwtstamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <14d568dc-46dd-4842-a4fb-ad92bd7a9bd5@lunn.ch>
Date: Wed, 12 Nov 2025 21:31:11 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Russell King <linux@...linux.org.uk>,
	Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Andrei Botila <andrei.botila@....nxp.com>,
	Richard Cochran <richardcochran@...il.com>,
	Simon Horman <horms@...nel.org>,
	Vladimir Oltean <vladimir.oltean@....com>,
	Jacob Keller <jacob.e.keller@...el.com>,
	Kory Maincent <kory.maincent@...tlin.com>,
	bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/8] phy: add hwtstamp_get callback to retrieve
 config

>  int phy_mii_ioctl(struct phy_device *phydev, struct ifreq *ifr, int cmd)
>  {
>  	struct mii_ioctl_data *mii_data = if_mii(ifr);
> -	struct kernel_hwtstamp_config kernel_cfg;
> +	struct kernel_hwtstamp_config kernel_cfg = {};
>  	struct netlink_ext_ack extack = {};
>  	u16 val = mii_data->val_in;
>  	bool change_autoneg = false;
> @@ -404,13 +404,29 @@ int phy_mii_ioctl(struct phy_device *phydev, struct ifreq *ifr, int cmd)
>  
>  		return 0;
>  
> +	case SIOCGHWTSTAMP:
> +		if (phydev->mii_ts && phydev->mii_ts->hwtstamp_get) {
> +			ret = phydev->mii_ts->hwtstamp_get(phydev->mii_ts,
> +							   &kernel_cfg);
> +			if (ret)
> +				return ret;
> +
> +			hwtstamp_config_from_kernel(&cfg, &kernel_cfg);
> +			if (copy_to_user(ifr->ifr_data, &cfg, sizeof(cfg)))
> +				return -EFAULT;
> +
> +			return 0;
> +		}
> +		return -EOPNOTSUPP;
>  	case SIOCSHWTSTAMP:
> -		if (phydev->mii_ts && phydev->mii_ts->hwtstamp) {
> +		if (phydev->mii_ts && phydev->mii_ts->hwtstamp_set) {
>  			if (copy_from_user(&cfg, ifr->ifr_data, sizeof(cfg)))
>  				return -EFAULT;
>  
>  			hwtstamp_config_to_kernel(&kernel_cfg, &cfg);
> -			ret = phydev->mii_ts->hwtstamp(phydev->mii_ts, &kernel_cfg, &extack);
> +			ret = phydev->mii_ts->hwtstamp_set(phydev->mii_ts,
> +							   &kernel_cfg,
> +							   &extack);

This is not about renaming a method. Please make it a separate patch.

> @@ -27,7 +27,9 @@ struct phy_device;
>   *		as soon as a timestamp becomes available. One of the PTP_CLASS_
>   *		values is passed in 'type'.
>   *
> - * @hwtstamp:	Handles SIOCSHWTSTAMP ioctl for hardware time stamping.
> + * @hwtstamp_set: Handles SIOCSHWTSTAMP ioctl for hardware time stamping.
> + *
> + * @hwtstamp_get: Handles SIOCGHWTSTAMP ioctl for hardware time stamping.

Adding _get should not be in this patch, which is all about renaming.

    Andrew

---
pw-bot: cr