netdev - Re: [PATCH net-next] net: phy: fixed_phy: use genphy_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f3ae628b-4cbd-4075-8e59-7e3d7ee872cf@gmail.com>
Date: Wed, 12 Nov 2025 21:28:05 +0100
From: Heiner Kallweit <hkallweit1@...il.com>
To: Russell King - ARM Linux <linux@...linux.org.uk>,
 Andrew Lunn <andrew@...n.ch>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
 David Miller <davem@...emloft.net>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: phy: fixed_phy: use genphy_read_abilities
 to simplify the code

On 11/10/2025 10:11 PM, Heiner Kallweit wrote:
> Populating phy->supported can be achieved easier by using
> genphy_read_abilities().
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
>  drivers/net/phy/fixed_phy.c | 23 +----------------------
>  1 file changed, 1 insertion(+), 22 deletions(-)
> 
> diff --git a/drivers/net/phy/fixed_phy.c b/drivers/net/phy/fixed_phy.c
> index 2e46b7aa6..32a9b99af 100644
> --- a/drivers/net/phy/fixed_phy.c
> +++ b/drivers/net/phy/fixed_phy.c
> @@ -18,7 +18,6 @@
>  #include <linux/of.h>
>  #include <linux/idr.h>
>  #include <linux/netdevice.h>
> -#include <linux/linkmode.h>
>  
>  #include "swphy.h"
>  
> @@ -157,27 +156,7 @@ struct phy_device *fixed_phy_register(const struct fixed_phy_status *status,
>  	phy->mdio.dev.of_node = np;
>  	phy->is_pseudo_fixed_link = true;
>  
> -	switch (status->speed) {
> -	case SPEED_1000:
> -		linkmode_set_bit(ETHTOOL_LINK_MODE_1000baseT_Half_BIT,
> -				 phy->supported);
> -		linkmode_set_bit(ETHTOOL_LINK_MODE_1000baseT_Full_BIT,
> -				 phy->supported);
> -		fallthrough;
> -	case SPEED_100:
> -		linkmode_set_bit(ETHTOOL_LINK_MODE_100baseT_Half_BIT,
> -				 phy->supported);
> -		linkmode_set_bit(ETHTOOL_LINK_MODE_100baseT_Full_BIT,
> -				 phy->supported);
> -		fallthrough;
> -	case SPEED_10:
> -	default:
> -		linkmode_set_bit(ETHTOOL_LINK_MODE_10baseT_Half_BIT,
> -				 phy->supported);
> -		linkmode_set_bit(ETHTOOL_LINK_MODE_10baseT_Full_BIT,
> -				 phy->supported);
> -	}
> -
> +	genphy_read_abilities(phy);
>  	phy_advertise_supported(phy);
>  
>  	ret = phy_device_register(phy);

After further checking, this code can be removed altogether.

--
pw-bot: cr