[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20251118091328.052c88d6@kernel.org>
Date: Tue, 18 Nov 2025 09:13:28 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Gal Pressman <gal@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
<edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Andrew Lunn
<andrew+netdev@...n.ch>, netdev@...r.kernel.org, Donald Hunter
<donald.hunter@...il.com>, Simon Horman <horms@...nel.org>, Alexei
Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>,
Jesper Dangaard Brouer <hawk@...nel.org>, John Fastabend
<john.fastabend@...il.com>, Stanislav Fomichev <sdf@...ichev.me>,
bpf@...r.kernel.org, Nimrod Oren <noren@...dia.com>
Subject: Re: [PATCH net-next 1/3] tools: ynl: cli: Add --list-attrs option
to show operation attributes
On Tue, 18 Nov 2025 11:38:04 +0200 Gal Pressman wrote:
> > Could you try to detect that do and dump replies are identical
> > and combine them? They are the same more often than not so
> > I think it'd be nice to avoid printing the same info twice.
>
> We need to take care of both cases where the whole operation is
> identical (e.g., ethtool debug-get), and cases where only the replies
> are identical (e.g., netdev dev-get). This kind of complicates the code.
I was thinking just the reply. This is mostly for GET type operations.
Request doesn't exist for DUMP, but for DO it carries ID.
> I'll give it a few more attempts, but maybe this should come as a
> followup to this series.
Powered by blists - more mailing lists