netdev - Re: [PATCH net-next 1/3] tools: ynl: cli: Add --list-attrs option to show operation attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <acf74a59-f399-4952-81d7-f99e13785fb2@nvidia.com>
Date: Wed, 19 Nov 2025 13:36:09 +0200
From: Gal Pressman <gal@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, netdev@...r.kernel.org,
 Donald Hunter <donald.hunter@...il.com>, Simon Horman <horms@...nel.org>,
 Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>,
 Jesper Dangaard Brouer <hawk@...nel.org>,
 John Fastabend <john.fastabend@...il.com>,
 Stanislav Fomichev <sdf@...ichev.me>, bpf@...r.kernel.org,
 Nimrod Oren <noren@...dia.com>
Subject: Re: [PATCH net-next 1/3] tools: ynl: cli: Add --list-attrs option to
 show operation attributes

On 18/11/2025 19:13, Jakub Kicinski wrote:
> On Tue, 18 Nov 2025 11:38:04 +0200 Gal Pressman wrote:
>>> Could you try to detect that do and dump replies are identical 
>>> and combine them? They are the same more often than not so 
>>> I think it'd be nice to avoid printing the same info twice.  
>>
>> We need to take care of both cases where the whole operation is
>> identical (e.g., ethtool debug-get), and cases where only the replies
>> are identical (e.g., netdev dev-get). This kind of complicates the code.
> 
> I was thinking just the reply. This is mostly for GET type operations.
> Request doesn't exist for DUMP, but for DO it carries ID.

Some dumps have requests, like ethtool's debug-get or strset-get.
I have a patch that detects identical replies, but it's quite ugly TBH.
I'd prefer to keep the code as is, but up to you.