netdev - Re: [PATCH net-next 3/5] selftests: hw-net: toeplitz: read the RSS key directly from C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ceb11201-0520-407b-b5ca-f32d1e3bfdee@davidwei.uk>
Date: Sat, 22 Nov 2025 18:07:46 -0800
From: David Wei <dw@...idwei.uk>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
 andrew+netdev@...n.ch, horms@...nel.org, willemb@...gle.com,
 petrm@...dia.com, shuah@...nel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next 3/5] selftests: hw-net: toeplitz: read the RSS
 key directly from C

On 2025-11-20 20:02, Jakub Kicinski wrote:
> Now that we have YNL support for RSS accessing the RSS info from
> C is very easy. Instead of passing the RSS key from Python do it
> directly in the C code.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>   .../testing/selftests/drivers/net/hw/Makefile |  6 ++-
>   .../selftests/drivers/net/hw/toeplitz.c       | 41 ++++++++++++++++++-
>   .../selftests/drivers/net/hw/toeplitz.py      |  5 ---
>   3 files changed, 44 insertions(+), 8 deletions(-)
> 
[...]
> diff --git a/tools/testing/selftests/drivers/net/hw/toeplitz.c b/tools/testing/selftests/drivers/net/hw/toeplitz.c
> index afc5f910b006..7420a4e201cc 100644
> --- a/tools/testing/selftests/drivers/net/hw/toeplitz.c
> +++ b/tools/testing/selftests/drivers/net/hw/toeplitz.c
[...]
> @@ -551,7 +590,7 @@ static void parse_opts(int argc, char **argv)
>   	}
>   
>   	if (!have_toeplitz)
> -		error(1, 0, "Must supply rss key ('-k')");
> +		read_rss_dev_info_ynl();

Do you also want to remove the case 'k' and other no longer used code,
or is there still a valid use for them e.g. someone calling `toeplitz`
manually?