netdev - [PATCH net-next] selftests: af_unix: don't use SKIP for expected failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251123021601.158709-1-kuba@kernel.org>
Date: Sat, 22 Nov 2025 18:16:01 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: davem@...emloft.net
Cc: netdev@...r.kernel.org,
	edumazet@...gle.com,
	pabeni@...hat.com,
	andrew+netdev@...n.ch,
	horms@...nel.org,
	Jakub Kicinski <kuba@...nel.org>,
	kuniyu@...gle.com,
	adelodunolaoluwa@...oo.com,
	shuah@...nel.org,
	linux-kselftest@...r.kernel.org
Subject: [PATCH net-next] selftests: af_unix: don't use SKIP for expected failures

netdev CI reserves SKIP in selftests for cases which can't be executed
due to setup issues, like missing or old commands. Tests which are
expected to fail must use XFAIL.

Signed-off-by: Jakub Kicinski <kuba@...nel.org>
---
CC: kuniyu@...gle.com
CC: adelodunolaoluwa@...oo.com
CC: shuah@...nel.org
CC: linux-kselftest@...r.kernel.org
---
 tools/testing/selftests/net/af_unix/unix_connreset.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/net/af_unix/unix_connreset.c b/tools/testing/selftests/net/af_unix/unix_connreset.c
index bffef2b54bfd..6eb936207b31 100644
--- a/tools/testing/selftests/net/af_unix/unix_connreset.c
+++ b/tools/testing/selftests/net/af_unix/unix_connreset.c
@@ -161,8 +161,12 @@ TEST_F(unix_sock, reset_closed_embryo)
 	char buf[16] = {};
 	ssize_t n;
 
-	if (variant->socket_type == SOCK_DGRAM)
-		SKIP(return, "This test only applies to SOCK_STREAM and SOCK_SEQPACKET");
+	if (variant->socket_type == SOCK_DGRAM) {
+		snprintf(_metadata->results->reason,
+			 sizeof(_metadata->results->reason),
+			 "Test only applies to SOCK_STREAM and SOCK_SEQPACKET");
+		exit(KSFT_XFAIL);
+	}
 
 	/* Close server without accept()ing */
 	close(self->server);
-- 
2.51.1