netdev - Re: [PATCH RFC bpf-next 15/15] bpf: Realign skb metadata for TC progs using data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87cy565gxw.fsf@cloudflare.com>
Date: Tue, 25 Nov 2025 15:23:55 +0100
From: Jakub Sitnicki <jakub@...udflare.com>
To: bot+bpf-ci@...nel.org
Cc: bpf@...r.kernel.org,  netdev@...r.kernel.org,
 kernel-team@...udflare.com, martin.lau@...ux.dev, ast@...nel.org,
 andrii@...nel.org, daniel@...earbox.net, martin.lau@...nel.org,
 eddyz87@...il.com, yonghong.song@...ux.dev, clm@...a.com,
 ihor.solodrai@...ux.dev
Subject: Re: [PATCH RFC bpf-next 15/15] bpf: Realign skb metadata for TC
 progs using data_meta

On Mon, Nov 24, 2025 at 04:58 PM GMT, bot+bpf-ci@...nel.org wrote:
> This appears to fix the bug introduced by commit 016079023cef ("net:
> Track skb metadata end separately from MAC offset"). Should this include
> a Fixes: tag?
>
> The earlier commit message explicitly noted: "Note that this breaks BPF
> skb metadata access through skb->data_meta when there is a gap between
> meta_end and skb->data. Following BPF verifier changes address this."
>
> This commit is one of those follow-up changes that addresses the
> breakage.

False-positive feedback, naturally. Both breaking change and the fix
belong to the same patch series, so Fixes tagging rules don't apply.