netdev - Re: [PATCH RFC bpf-next 15/15] bpf: Realign skb metadata for TC progs using data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6bd2a44a-0e79-497b-8add-2db8bff81f28@meta.com>
Date: Tue, 25 Nov 2025 09:52:00 -0500
From: Chris Mason <clm@...a.com>
To: Jakub Sitnicki <jakub@...udflare.com>, bot+bpf-ci@...nel.org
Cc: bpf@...r.kernel.org, netdev@...r.kernel.org, kernel-team@...udflare.com,
        martin.lau@...ux.dev, ast@...nel.org, andrii@...nel.org,
        daniel@...earbox.net, martin.lau@...nel.org, eddyz87@...il.com,
        yonghong.song@...ux.dev, ihor.solodrai@...ux.dev
Subject: Re: [PATCH RFC bpf-next 15/15] bpf: Realign skb metadata for TC progs
 using data_meta



On 11/25/25 9:23 AM, Jakub Sitnicki wrote:
> On Mon, Nov 24, 2025 at 04:58 PM GMT, bot+bpf-ci@...nel.org wrote:
>> This appears to fix the bug introduced by commit 016079023cef ("net:
>> Track skb metadata end separately from MAC offset"). Should this include
>> a Fixes: tag?
>>
>> The earlier commit message explicitly noted: "Note that this breaks BPF
>> skb metadata access through skb->data_meta when there is a gap between
>> meta_end and skb->data. Following BPF verifier changes address this."
>>
>> This commit is one of those follow-up changes that addresses the
>> breakage.
> 
> False-positive feedback, naturally. Both breaking change and the fix
> belong to the same patch series, so Fixes tagging rules don't apply.

Thanks, I disabled the Fixes: tag checks until I can beef them up a bit.
 Sounds like I need to get the patch series aware reviews working first.

-chris