netdev - Re: [PATCH net-next] net: Remove KMSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1cece62-ee31-465c-8284-a8117e939bca@linux.ibm.com>
Date: Wed, 26 Nov 2025 17:05:47 +0100
From: Alexandra Winter <wintera@...ux.ibm.com>
To: Heiko Carstens <hca@...ux.ibm.com>,
        "David S . Miller"
 <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Jozsef Kadlecsik <kadlec@...filter.org>,
        Florian Westphal <fw@...len.de>,
        "D . Wythe" <alibuda@...ux.alibaba.com>,
        Dust Li
 <dust.li@...ux.alibaba.com>,
        Sidraya Jayagond <sidraya@...ux.ibm.com>,
        Wenjia Zhang <wenjia@...ux.ibm.com>,
        Thorsten Winkler <twinkler@...ux.ibm.com>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: Remove KMSG_COMPONENT macro



On 26.11.25 15:07, Heiko Carstens wrote:
> The KMSG_COMPONENT macro is a leftover of the s390 specific "kernel message
> catalog" from 2008 [1] which never made it upstream.
> 
> The macro was added to s390 code to allow for an out-of-tree patch which
> used this to generate unique message ids. Also this out-of-tree patch
> doesn't exist anymore.
> 
> The pattern of how the KMSG_COMPONENT macro is used can also be found at
> some non s390 specific code, for whatever reasons. Besides adding an
> indirection it is unused.
> 
> Remove the macro in order to get rid of a pointless indirection. Replace
> all users with the string it defines. In all cases this leads to a simple
> replacement like this:
> 
>  - #define KMSG_COMPONENT "af_iucv"
>  - #define pr_fmt(fmt) KMSG_COMPONENT ": " fmt
>  + #define pr_fmt(fmt) "af_iucv: " fmt
> 
> [1] https://lwn.net/Articles/292650/
> 
> Signed-off-by: Heiko Carstens <hca@...ux.ibm.com>
> ---
>  net/iucv/af_iucv.c                      | 3 +--
>  net/iucv/iucv.c                         | 3 +--

For net/iucv:
Acked-by: Alexandra Winter <wintera@...ux.ibm.com>