netdev - Re: [PATCH net-next] dibs: Remove KMSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <811ab9a1-e548-4965-9188-4b30d41a757a@linux.ibm.com>
Date: Wed, 26 Nov 2025 17:06:10 +0100
From: Alexandra Winter <wintera@...ux.ibm.com>
To: Heiko Carstens <hca@...ux.ibm.com>,
        "David S . Miller"
 <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next] dibs: Remove KMSG_COMPONENT macro



On 26.11.25 15:22, Heiko Carstens wrote:
> The KMSG_COMPONENT macro is a leftover of the s390 specific "kernel message
> catalog" from 2008 [1] which never made it upstream.
> 
> The macro was added to s390 code to allow for an out-of-tree patch which
> used this to generate unique message ids. Also this out-of-tree doesn't
> exist anymore.
> 
> The pattern of how the KMSG_COMPONENT is used was partially also used for
> non s390 specific code, for whatever reasons.
> 
> Remove the macro in order to get rid of a pointless indirection.
> 
> [1] https://lwn.net/Articles/292650/
> 
> Signed-off-by: Heiko Carstens <hca@...ux.ibm.com>
> ---
>  drivers/dibs/dibs_main.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/dibs/dibs_main.c b/drivers/dibs/dibs_main.c
> index dac14d843af7..b8c16586706c 100644
> --- a/drivers/dibs/dibs_main.c
> +++ b/drivers/dibs/dibs_main.c
> @@ -6,8 +6,7 @@
>   *
>   *  Copyright IBM Corp. 2025
>   */
> -#define KMSG_COMPONENT "dibs"
> -#define pr_fmt(fmt) KMSG_COMPONENT ": " fmt
> +#define pr_fmt(fmt) "dibs: " fmt
>  
>  #include <linux/module.h>
>  #include <linux/types.h>

Acked-by: Alexandra Winter <wintera@...ux.ibm.com>