netdev - Re: [PATCH net-next v5 00/16] net: introduce QUIC infrastructure and core subcomponents

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADvbK_crxSB+TwDgEtjV6TUEeO9VYtsE6rqy7L_=rzoDrCfORQ@mail.gmail.com>
Date: Fri, 28 Nov 2025 17:21:30 -0500
From: Xin Long <lucien.xin@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: network dev <netdev@...r.kernel.org>, quic@...ts.linux.dev, davem@...emloft.net, 
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Stefan Metzmacher <metze@...ba.org>, Moritz Buhl <mbuhl@...nbsd.org>, Tyler Fanelli <tfanelli@...hat.com>, 
	Pengtao He <hepengtao@...omi.com>, Thomas Dreibholz <dreibh@...ula.no>, linux-cifs@...r.kernel.org, 
	Steve French <smfrench@...il.com>, Namjae Jeon <linkinjeon@...nel.org>, 
	Paulo Alcantara <pc@...guebit.com>, Tom Talpey <tom@...pey.com>, kernel-tls-handshake@...ts.linux.dev, 
	Chuck Lever <chuck.lever@...cle.com>, Jeff Layton <jlayton@...nel.org>, 
	Steve Dickson <steved@...hat.com>, Hannes Reinecke <hare@...e.de>, Alexander Aring <aahringo@...hat.com>, 
	David Howells <dhowells@...hat.com>, Matthieu Baerts <matttbe@...nel.org>, 
	John Ericson <mail@...nericson.me>, Cong Wang <xiyou.wangcong@...il.com>, 
	"D . Wythe" <alibuda@...ux.alibaba.com>, Jason Baron <jbaron@...mai.com>, 
	illiliti <illiliti@...tonmail.com>, Sabrina Dubroca <sd@...asysnail.net>, 
	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>, Daniel Stenberg <daniel@...x.se>, 
	Andy Gospodarek <andrew.gospodarek@...adcom.com>
Subject: Re: [PATCH net-next v5 00/16] net: introduce QUIC infrastructure and
 core subcomponents

On Thu, Nov 27, 2025 at 9:30 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Mon, 24 Nov 2025 09:28:13 -0500 Xin Long wrote:
> > The QUIC protocol, defined in RFC 9000, is a secure, multiplexed transport
> > built on top of UDP. It enables low-latency connection establishment,
> > stream-based communication with flow control, and supports connection
> > migration across network paths, while ensuring confidentiality, integrity,
> > and availability.
>
> Please look thru the Claude review and address the legit complaints:
>
> https://netdev-ai.bots.linux.dev/ai-review.html?id=8ac157b3-6222-4e89-ac52-28e4ca52d6c4
>
> If the tool is confused but not in an dumb way - it may be worth adding
> a relevant comment or info in the commit message. Otherwise a note under
> --- would be appreciated to avoid maintainers having to re-check the
> comments you already considered and disproved.
Thanks for the link.

I just went through the tool’s report. It found one real issue in
quic_packet_backlog_work(), which I’ll fix. The other items aren’t
actual problems, and I’ll add some inline comments or --- notes to
explain them.

>
> Thanks for adding the MAINTAINERS entry, two notes on that:
>  - the entries must be sorted, so you need to move it down under Q
>    instead of putting it next to SCTP
>  - you seem to have copy/pasted the uAPI path for SCTP to the entry
>    instead of QUIC ;)
You're right, thanks!