netdev - [PATCH net] udp: remove obsolete SNMP TODO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251213121024.219353-1-mahdifrmx@gmail.com>
Date: Sat, 13 Dec 2025 15:40:24 +0330
From: Mahdi Faramarzpour <mahdifrmx@...il.com>
To: netdev@...r.kernel.org,
	kuba@...nel.org,
	edumazet@...gle.com
Cc: Mahdi Faramarzpour <mahdifrmx@...il.com>
Subject: [PATCH net] udp: remove obsolete SNMP TODO

The TODO comment demands SNMP counters be increased, and that
is already implemented by the callers of __udp_enqueue_schedule_skb()
which are __udp_queue_rcv_skb() and __udpv6_queue_rcv_skb().

That makes the TODO obsolete.

Signed-off-by: Mahdi Faramarzpour <mahdifrmx@...il.com>
---
 net/ipv4/udp.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
index ffe074cb5..60d549a24 100644
--- a/net/ipv4/udp.c
+++ b/net/ipv4/udp.c
@@ -1797,7 +1797,6 @@ int __udp_enqueue_schedule_skb(struct sock *sk, struct sk_buff *skb)
 			skb = to_drop;
 			to_drop = skb->next;
 			skb_mark_not_on_list(skb);
-			/* TODO: update SNMP values. */
 			sk_skb_reason_drop(sk, skb, SKB_DROP_REASON_PROTO_MEM);
 		}
 		numa_drop_add(&udp_sk(sk)->drop_counters, nb);
-- 
2.34.1