netdev - Re: [PATCH net] udp: remove obsolete SNMP TODO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJnV=ea+bP3LCF7FKVAXrvc5qHd9j9yrgv50-rFaPO0ig@mail.gmail.com>
Date: Sat, 13 Dec 2025 14:36:41 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Mahdi Faramarzpour <mahdifrmx@...il.com>
Cc: netdev@...r.kernel.org, kuba@...nel.org
Subject: Re: [PATCH net] udp: remove obsolete SNMP TODO

On Sat, Dec 13, 2025 at 1:11 PM Mahdi Faramarzpour <mahdifrmx@...il.com> wrote:
>
> The TODO comment demands SNMP counters be increased, and that
> is already implemented by the callers of __udp_enqueue_schedule_skb()
> which are __udp_queue_rcv_skb() and __udpv6_queue_rcv_skb().
>
> That makes the TODO obsolete.

This is not true.

Please carefully read commit b650bf0977d3 ("udp: remove busylock and
add per NUMA queues")
And perhaps you will see what needs to be changed, thus the TODO .

hint : to_drop can contain more than one skb.

>
> Signed-off-by: Mahdi Faramarzpour <mahdifrmx@...il.com>
> ---
>  net/ipv4/udp.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
> index ffe074cb5..60d549a24 100644
> --- a/net/ipv4/udp.c
> +++ b/net/ipv4/udp.c
> @@ -1797,7 +1797,6 @@ int __udp_enqueue_schedule_skb(struct sock *sk, struct sk_buff *skb)
>                         skb = to_drop;
>                         to_drop = skb->next;
>                         skb_mark_not_on_list(skb);
> -                       /* TODO: update SNMP values. */
>                         sk_skb_reason_drop(sk, skb, SKB_DROP_REASON_PROTO_MEM);
>                 }
>                 numa_drop_add(&udp_sk(sk)->drop_counters, nb);
> --
> 2.34.1
>