netdev - Re: [PATCH] RDMA/rxe: let rxe_reclassify_recv_socket() call sk_owner

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <01cd3f5a-2976-45ad-8a2d-32b3e39c6317@samba.org>
Date: Sat, 20 Dec 2025 14:05:15 +0100
From: Stefan Metzmacher <metze@...ba.org>
To: Zhu Yanjun <yanjun.zhu@...ux.dev>, linux-rdma@...r.kernel.org
Cc: Zhu Yanjun <zyjzyj2000@...il.com>, Jason Gunthorpe <jgg@...pe.ca>,
 Leon Romanovsky <leon@...nel.org>,
 Shinichiro Kawasaki <shinichiro.kawasaki@....com>, netdev@...r.kernel.org,
 linux-cifs@...r.kernel.org
Subject: Re: [PATCH] RDMA/rxe: let rxe_reclassify_recv_socket() call
 sk_owner_put()

Am 20.12.25 um 04:51 schrieb Zhu Yanjun:
> 在 2025/12/19 6:04, Stefan Metzmacher 写道:
>> On kernels build with CONFIG_PROVE_LOCKING, CONFIG_MODULES
>> and CONFIG_DEBUG_LOCK_ALLOC 'rmmod rdma_rxe' is no longer
>> possible.
>>
>> For the global recv sockets rxe_net_exit() is where we
>> call rxe_release_udp_tunnel-> udp_tunnel_sock_release(),
>> which means the sockets are destroyed before 'rmmod rdma_rxe'
>> finishes, so there's no need to protect against
>> rxe_recv_slock_key and rxe_recv_sk_key disappearing
>> while the sockets are still alive.
>>
>> Fixes: 80a85a771deb ("RDMA/rxe: reclassify sockets in order to avoid false positives from lockdep")
>> Cc: Zhu Yanjun <zyjzyj2000@...il.com>
>> Cc: Jason Gunthorpe <jgg@...pe.ca>
>> Cc: Leon Romanovsky <leon@...nel.org>
>> Cc: Shinichiro Kawasaki <shinichiro.kawasaki@....com>
>> Cc: linux-rdma@...r.kernel.org
>> Cc: netdev@...r.kernel.org
>> Cc: linux-cifs@...r.kernel.org
>> Signed-off-by: Stefan Metzmacher <metze@...ba.org>
> 
> Thanks a lot. IIRC, there is a similar commit for SIW driver. Thus, I am not sure if there is a similar problem in SIW driver or not.

I don't think so, siw and the other place in rxe  are attached to specific connections
and there the reference is ok and needed.

The problem was only related to the two global sockets with the lifetime
the rdma_rxe is loaded.

metze