netdev - Re: [PATCH] RDMA/rxe: let rxe_reclassify_recv_socket() call sk_owner

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <94f0a1c1-df51-4515-a08f-1e90cfe34f31@wdc.com>
Date: Sat, 20 Dec 2025 05:19:22 +0000
From: Shinichiro Kawasaki <shinichiro.kawasaki@....com>
To: Stefan Metzmacher <metze@...ba.org>, "linux-rdma@...r.kernel.org"
	<linux-rdma@...r.kernel.org>
CC: Zhu Yanjun <zyjzyj2000@...il.com>, Jason Gunthorpe <jgg@...pe.ca>, Leon
 Romanovsky <leon@...nel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-cifs@...r.kernel.org"
	<linux-cifs@...r.kernel.org>
Subject: Re: [PATCH] RDMA/rxe: let rxe_reclassify_recv_socket() call
 sk_owner_put()

On 12/19/25 11:04 PM, Stefan Metzmacher wrote:
> On kernels build with CONFIG_PROVE_LOCKING, CONFIG_MODULES
> and CONFIG_DEBUG_LOCK_ALLOC 'rmmod rdma_rxe' is no longer
> possible.
> 
> For the global recv sockets rxe_net_exit() is where we
> call rxe_release_udp_tunnel-> udp_tunnel_sock_release(),
> which means the sockets are destroyed before 'rmmod rdma_rxe'
> finishes, so there's no need to protect against
> rxe_recv_slock_key and rxe_recv_sk_key disappearing
> while the sockets are still alive.
> 
> Fixes: 80a85a771deb ("RDMA/rxe: reclassify sockets in order to avoid false positives from lockdep")
> Cc: Zhu Yanjun <zyjzyj2000@...il.com>
> Cc: Jason Gunthorpe <jgg@...pe.ca>
> Cc: Leon Romanovsky <leon@...nel.org>
> Cc: Shinichiro Kawasaki <shinichiro.kawasaki@....com>
> Cc: linux-rdma@...r.kernel.org
> Cc: netdev@...r.kernel.org
> Cc: linux-cifs@...r.kernel.org
> Signed-off-by: Stefan Metzmacher <metze@...ba.org>

I applied this patch on top of v6.19-rc1 kernel, and confirmed the
failure I had reported [1] is no longer observed. Thank you :)

Tested-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@....com>

[1] https://lore.kernel.org/linux-rdma/170e3191-7e15-4af8-948f-14904fe260cc@wdc.com/