netdev - Re: [PATCH v2 1/2] net: phy: adin: enable configuration of the LP Termination Register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1e75d9b-0c49-4c52-a77c-c6fe3918e4d6@linux.dev>
Date: Tue, 23 Dec 2025 07:36:30 +0000
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Osose Itua <osose.itua@...oirfairelinux.com>, netdev@...r.kernel.org
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 michael.hennerich@...log.com, jerome.oufella@...oirfairelinux.com
Subject: Re: [PATCH v2 1/2] net: phy: adin: enable configuration of the LP
 Termination Register

On 22/12/2025 22:21, Osose Itua wrote:
> The ADIN1200/ADIN1300 provide a control bit that selects between normal
> receive termination and the lowest common mode impedance for 100BASE-TX
> operation. This behavior is controlled through the Low Power Termination
> register (B_100_ZPTM_EN_DIMRX).
> 
> Bit 0 of this register enables normal termination when set (this is the
> default), and selects the lowest common mode impedance when cleared.
> 
> Signed-off-by: Osose Itua <osose.itua@...oirfairelinux.com>
> ---
>   drivers/net/phy/adin.c | 34 ++++++++++++++++++++++++++++++++++
>   1 file changed, 34 insertions(+)
> 
> diff --git a/drivers/net/phy/adin.c b/drivers/net/phy/adin.c
> index 7fa713ca8d45..e8b778cb191d 100644
> --- a/drivers/net/phy/adin.c
> +++ b/drivers/net/phy/adin.c
> @@ -4,6 +4,7 @@
>    *
>    * Copyright 2019 Analog Devices Inc.
>    */
> +#include <cerrno>

This kind of include is not used in kernel.
You don't need to include anything in this file to have EINVAL defined.

>   #include <linux/kernel.h>
>   #include <linux/bitfield.h>
>   #include <linux/delay.h>
> @@ -89,6 +90,9 @@