netdev - Re: [PATCH net-next 10/15] net: dsa: tag_rtl4_a: use the dsa_xmit_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJq09z713UGs0LRzs+J=iNs+frwozSg-9g0x+Zg2xg+0F+4J5Q@mail.gmail.com>
Date: Wed, 31 Dec 2025 00:17:17 -0300
From: Luiz Angelo Daros de Luca <luizluca@...il.com>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Linus Walleij <linus.walleij@...aro.org>, Alvin Šipraga <alsi@...g-olufsen.dk>
Subject: Re: [PATCH net-next 10/15] net: dsa: tag_rtl4_a: use the
 dsa_xmit_port_mask() helper

>         out = (RTL4_A_PROTOCOL_RTL8366RB << RTL4_A_PROTOCOL_SHIFT);
>         /* The lower bits indicate the port number */
> -       out |= BIT(dp->index);
> +       out |= dsa_xmit_port_mask(skb, dev);
>
>         p = (__be16 *)(tag + 2);
>         *p = htons(out);
> --

It looks like overkill for this simple switch ASIC but it will work as before.

Reviewed-by: Luiz Angelo Daros de Luca <luizluca@...il.com>