netdev - Re: [PATCH net-next 11/15] net: dsa: tag_rtl8_4: use the dsa_xmit_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJq09z4nOL_JCmVLM87sDYBn4+1c29Fed9mGoqMQahgUJrZfyA@mail.gmail.com>
Date: Wed, 31 Dec 2025 00:20:06 -0300
From: Luiz Angelo Daros de Luca <luizluca@...il.com>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Linus Walleij <linus.walleij@...aro.org>, Alvin Šipraga <alsi@...g-olufsen.dk>
Subject: Re: [PATCH net-next 11/15] net: dsa: tag_rtl8_4: use the
 dsa_xmit_port_mask() helper

> diff --git a/net/dsa/tag_rtl8_4.c b/net/dsa/tag_rtl8_4.c
> index 15c2bae2b429..2464545da4d2 100644
> --- a/net/dsa/tag_rtl8_4.c
> +++ b/net/dsa/tag_rtl8_4.c
> @@ -103,7 +103,6 @@
>  static void rtl8_4_write_tag(struct sk_buff *skb, struct net_device *dev,
>                              void *tag)
>  {
> -       struct dsa_port *dp = dsa_user_to_port(dev);
>         __be16 tag16[RTL8_4_TAG_LEN / 2];
>
>         /* Set Realtek EtherType */
> @@ -116,7 +115,7 @@ static void rtl8_4_write_tag(struct sk_buff *skb, struct net_device *dev,
>         tag16[2] = htons(FIELD_PREP(RTL8_4_LEARN_DIS, 1));
>
>         /* Zero ALLOW; set RX (CPU->switch) forwarding port mask */
> -       tag16[3] = htons(FIELD_PREP(RTL8_4_RX, BIT(dp->index)));
> +       tag16[3] = htons(FIELD_PREP(RTL8_4_RX, dsa_xmit_port_mask(skb, dev)));
>
>         memcpy(tag, tag16, RTL8_4_TAG_LEN);
>  }
> --

Reviewed-by: Luiz Angelo Daros de Luca <luizluca@...il.com>