netdev - [PATCH v5] net: dsa: realtek: rtl8365mb: fix return value in rtl8365mb_phy_ocp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <a2dfde3c-d46f-434b-9d16-1e251e449068@yahoo.com>
Date: Mon, 5 Jan 2026 09:41:50 +0100
From: Mieczyslaw Nalewaj <namiltd@...oo.com>
To: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc: "alsi@...g-olufsen.dk" <alsi@...g-olufsen.dk>,
 "olteanv@...il.com" <olteanv@...il.com>, Andrew Lunn <andrew@...n.ch>,
 "davem@...emloft.net" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Subject: [PATCH v5] net: dsa: realtek: rtl8365mb: fix return value in
 rtl8365mb_phy_ocp_write

Function rtl8365mb_phy_ocp_write() always returns 0, even when an error
occurs during register access. This patch fixes the return value to
propagate the actual error code from regmap operations.

Fixes: 2796728460b8 ("net: dsa: realtek: rtl8365mb: serialize indirect PHY register access")

Signed-off-by: Mieczyslaw Nalewaj <namiltd@...oo.com>
---
 drivers/net/dsa/realtek/rtl8365mb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/dsa/realtek/rtl8365mb.c
+++ b/drivers/net/dsa/realtek/rtl8365mb.c
@@ -881,7 +881,7 @@ static int rtl8365mb_phy_ocp_write(struc
 out:
 	rtl83xx_unlock(priv);
 
-	return 0;
+	return ret;
 }
 
 static int rtl8365mb_phy_read(struct realtek_priv *priv, int phy, int regnum)