netdev - Re: [PATCH v5] net: dsa: realtek: rtl8365mb: fix return value in rtl8365mb_phy_ocp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c161c178-e4c1-4b71-beee-002407c28fe4@lunn.ch>
Date: Mon, 5 Jan 2026 15:39:57 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Mieczyslaw Nalewaj <namiltd@...oo.com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"alsi@...g-olufsen.dk" <alsi@...g-olufsen.dk>,
	"olteanv@...il.com" <olteanv@...il.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH v5] net: dsa: realtek: rtl8365mb: fix return value in
 rtl8365mb_phy_ocp_write

On Mon, Jan 05, 2026 at 09:41:50AM +0100, Mieczyslaw Nalewaj wrote:
> Function rtl8365mb_phy_ocp_write() always returns 0, even when an error
> occurs during register access. This patch fixes the return value to
> propagate the actual error code from regmap operations.
> 
> Fixes: 2796728460b8 ("net: dsa: realtek: rtl8365mb: serialize indirect PHY register access")
> 
> Signed-off-by: Mieczyslaw Nalewaj <namiltd@...oo.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

> ---

This is v5 of the patch. It would be normal to have the history of the
patch under the ---. Please remember that for the future.

	Andrew