netdev - Re: [PATCH RFC net-next v4 3/4] net: mdio: add unlocked mdiodev C45 bus accessors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aV2OWT4g0jwfS548@makrotopia.org>
Date: Tue, 6 Jan 2026 22:36:09 +0000
From: Daniel Golle <daniel@...rotopia.org>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Andrew Lunn <andrew@...n.ch>, Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Simon Horman <horms@...nel.org>, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Frank Wunderlich <frankwu@....de>, Chad Monroe <chad@...roe.io>,
	Cezary Wilmanski <cezary.wilmanski@...ran.com>,
	Avinash Jayaraman <ajayaraman@...linear.com>,
	Bing tao Xu <bxu@...linear.com>, Liang Xu <lxu@...linear.com>,
	Juraj Povazanec <jpovazanec@...linear.com>,
	"Fanni (Fang-Yi) Chan" <fchan@...linear.com>,
	"Benny (Ying-Tsan) Weng" <yweng@...linear.com>,
	"Livia M. Rosu" <lrosu@...linear.com>,
	John Crispin <john@...ozen.org>
Subject: Re: [PATCH RFC net-next v4 3/4] net: mdio: add unlocked mdiodev C45
 bus accessors

On Tue, Jan 06, 2026 at 05:53:29PM +0000, Russell King (Oracle) wrote:
> On Tue, Jan 06, 2026 at 05:14:57PM +0000, Daniel Golle wrote:
> > +static inline int __mdiodev_c45_write(struct mdio_device *mdiodev, u32 devad,
> > +				      u16 regnum, u16 val)
> > +{
> > +	return __mdiobus_c45_write(mdiodev->bus, mdiodev->addr, devad, regnum,
> > +				 val);
> 
> Something doesn't look right here - missing a couple of spaces to
> correctly align? I suspect checkpatch would spot it?

Somehow those two spaces got dropped somewhere on the way. Strangely
neither checkpatch.pl locally nor on patchwork[1] caught that -- maybe
because 'return' statements are somehow treated differently?

Anyway, fixed in my local tree now and going to be fixed in v5.

Are you otherwise fine with adding those unlocked mdiodev c45 helpers?


[1]: https://patchwork.kernel.org/project/netdevbpf/patch/36fbca0aaa0ca86450c565190931d987931ab958.1767718090.git.daniel@makrotopia.org/