netdev - RE: [PATCH RFC net-next v4 3/4] net: mdio: add unlocked mdiodev C45 bus accessors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SA1PR19MB6767B8366174EF508B29E604BD84A@SA1PR19MB6767.namprd19.prod.outlook.com>
Date: Wed, 7 Jan 2026 09:24:21 +0000
From: Liang Xu <lxu@...linear.com>
To: Daniel Golle <daniel@...rotopia.org>, "Russell King (Oracle)"
	<linux@...linux.org.uk>
CC: Andrew Lunn <andrew@...n.ch>, Vladimir Oltean <olteanv@...il.com>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring
	<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>, Heiner Kallweit <hkallweit1@...il.com>, Simon Horman
	<horms@...nel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Frank
 Wunderlich <frankwu@....de>, Chad Monroe <chad@...roe.io>, Cezary Wilmanski
	<cezary.wilmanski@...ran.com>, Avinash Jayaraman <ajayaraman@...linear.com>,
	Bing tao Xu <bxu@...linear.com>, Juraj Povazanec <jpovazanec@...linear.com>,
	"Fanni (Fang-Yi) Chan" <fchan@...linear.com>, "Benny (Ying-Tsan) Weng"
	<yweng@...linear.com>, "Livia M. Rosu" <lrosu@...linear.com>, John Crispin
	<john@...ozen.org>
Subject: RE: [PATCH RFC net-next v4 3/4] net: mdio: add unlocked mdiodev C45
 bus accessors

Hi Daniel,

I attached the tools usually included in the FW release for both version 1.0.59.59 v003F and 1.0.76.76 v0061.
Here is briefing of the tools:
        fullimage_update - update the configuration in the fullimage
        start_cfg - compile the start config (pre-configuration)

In start_cfg, you can check the file cfg_in_seq_attached.c.
All the host API described in the CHM files (I sent last time) can be used in this file.
They are invoked in sequence during system boot up.
Run "mk.sh" to compile it into a binary file - start_cfg.bin.
Then use command " ./fullimage_update --start-cfg start_cfg.bin 16384 f48x_full_image.bin" to generate a new fullimage file.

You can play with it and let me know if you have questions.

Thanks & Regards,
Xu Liang

-----Original Message-----
From: Daniel Golle <daniel@...rotopia.org>
Sent: Wednesday, January 7, 2026 6:36 AM
To: Russell King (Oracle) <linux@...linux.org.uk>
Cc: Andrew Lunn <andrew@...n.ch>; Vladimir Oltean <olteanv@...il.com>; David S. Miller <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Rob Herring <robh@...nel.org>; Krzysztof Kozlowski <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>; Heiner Kallweit <hkallweit1@...il.com>; Simon Horman <horms@...nel.org>; netdev@...r.kernel.org; devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; Frank Wunderlich <frankwu@....de>; Chad Monroe <chad@...roe.io>; Cezary Wilmanski <cezary.wilmanski@...ran.com>; Avinash Jayaraman <ajayaraman@...linear.com>; Bing tao Xu <bxu@...linear.com>; Liang Xu <lxu@...linear.com>; Juraj Povazanec <jpovazanec@...linear.com>; Fanni (Fang-Yi) Chan <fchan@...linear.com>; Benny (Ying-Tsan) Weng <yweng@...linear.com>; Livia M. Rosu <lrosu@...linear.com>; John Crispin <john@...ozen.org>
Subject: Re: [PATCH RFC net-next v4 3/4] net: mdio: add unlocked mdiodev C45 bus accessors

This email was sent from outside of MaxLinear.


On Tue, Jan 06, 2026 at 05:53:29PM +0000, Russell King (Oracle) wrote:
> On Tue, Jan 06, 2026 at 05:14:57PM +0000, Daniel Golle wrote:
> > +static inline int __mdiodev_c45_write(struct mdio_device *mdiodev, u32 devad,
> > +                                 u16 regnum, u16 val) {
> > +   return __mdiobus_c45_write(mdiodev->bus, mdiodev->addr, devad, regnum,
> > +                            val);
>
> Something doesn't look right here - missing a couple of spaces to
> correctly align? I suspect checkpatch would spot it?

Somehow those two spaces got dropped somewhere on the way. Strangely neither checkpatch.pl locally nor on patchwork[1] caught that -- maybe because 'return' statements are somehow treated differently?

Anyway, fixed in my local tree now and going to be fixed in v5.

Are you otherwise fine with adding those unlocked mdiodev c45 helpers?


[1]: https://patchwork.kernel.org/project/netdevbpf/patch/36fbca0aaa0ca86450c565190931d987931ab958.1767718090.git.daniel@makrotopia.org/

Content of type "application/octet-stream" skipped

Content truncated