netdev - Re: [PATCH v2 net 2/2] selftests: vlan: add test for turn on hw offload with reorder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260109175220.GM345651@kernel.org>
Date: Fri, 9 Jan 2026 17:52:20 +0000
From: Simon Horman <horms@...nel.org>
To: Chen Zhen <chenzhen126@...wei.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, huyizhen2@...wei.com,
	gaoxingwang1@...wei.com
Subject: Re: [PATCH v2 net 2/2] selftests: vlan: add test for turn on hw
 offload with reorder_hdr off

On Wed, Jan 07, 2026 at 11:34:23AM +0800, Chen Zhen wrote:
> If vlan dev was created with reorder_hdr off and hw offload both
> off but up with hw offload on, it will trigger a skb_panic bug in
> vlan_dev_hard_header().
> 
> Add a test to automatically catch re-occurrence of the issue.
> 
> Suggested-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Chen Zhen <chenzhen126@...wei.com>

Shellcheck warns that cleanup is never invoked.

  SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).

But is only true if only direct invocations are taken into
account (which I assume is what shellcheck does).
cleanup is actually called on exit as it has been
registered to do so by trap.

In order to keep shellcheck quiet I'd recommend adding the following
to vlan_hw_offload.sh.

#shellcheck disable=SC2329

...