netdev - Re: [PATCH net-next v3] octeon_ep: reset firmware ready status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260110121349.25eb40ce@kernel.org>
Date: Sat, 10 Jan 2026 12:13:49 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Vimlesh Kumar <vimleshk@...vell.com>
Cc: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <sedara@...vell.com>, <srasheed@...vell.com>, <hgani@...vell.com>,
 Veerasenareddy Burru <vburru@...vell.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, "Paolo Abeni" <pabeni@...hat.com>
Subject: Re: [PATCH net-next v3] octeon_ep: reset firmware ready status

On Wed, 7 Jan 2026 13:45:02 +0000 Vimlesh Kumar wrote:
> +#define CN9K_PEMX_PFX_CSX_PFCFGX(pem, pf, offset)\
> +				 ({ typeof(offset) _off = (offset);\
> +				 ((CN9K_PFX_CSX_PFCFGX_BASE_ADDR\
> +				 | (uint64_t)FIELD_PREP(CN9K_PEM_GENMASK, pem)\
> +				 | FIELD_PREP(CN9K_PF_GENMASK, pf)\
> +				 | (CN9K_PFX_CSX_PFCFGX_SHADOW_BIT & (_off))\
> +				 | (rounddown((_off), 8)))\
> +				 + (CN9K_4BYTE_ALIGNED_ADDRESS_OFFSET(_off)));\
> +				 })

This macro is completely unreadable. Maybe add a static inline to
perform the CN9K_PEMX_PFX_CSX_PFCFGX() writes.
-- 
pw-bot: cr