netdev - Re: [PATCH net-next] net: usb: dm9601: remove broken SR9700 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87zf6ix7pl.fsf@dell.be.48ers.dk>
Date: Tue, 13 Jan 2026 09:00:54 +0100
From: Peter Korsgaard <peter@...sgaard.com>
To: Ethan Nelson-Moore <enelsonmoore@...il.com>
Cc: netdev@...r.kernel.org,  linux-usb@...r.kernel.org,  Andrew Lunn
 <andrew+netdev@...n.ch>,  "David S. Miller" <davem@...emloft.net>,  Eric
 Dumazet <edumazet@...gle.com>,  Jakub Kicinski <kuba@...nel.org>,  Paolo
 Abeni <pabeni@...hat.com>,  Liu Junliang <liujunliang_ljl@....com>
Subject: Re: [PATCH net-next] net: usb: dm9601: remove broken SR9700 support

>>>>> "Ethan" == Ethan Nelson-Moore <enelsonmoore@...il.com> writes:

 > The SR9700 chip sends more than one packet in a USB transaction,
 > like the DM962x chips can optionally do, but the dm9601 driver does not
 > support this mode, and the hardware does not have the DM962x
 > MODE_CTL register to disable it, so this driver drops packets on SR9700
 > devices. The sr9700 driver correctly handles receiving more than one
 > packet per transaction.

 > While the dm9601 driver could be improved to handle this, the easiest
 > way to fix this issue in the short term is to remove the SR9700 device
 > ID from the dm9601 driver so the sr9700 driver is always used. This
 > device ID should not have been in more than one driver to begin with.

 > The "Fixes" commit was chosen so that the patch is automatically
 > included in all kernels that have the sr9700 driver, even though the
 > issue affects dm9601.

 > Fixes: c9b37458e956 ("USB2NET : SR9700 : One chip USB 1.1 USB2NET
 > SR9700Device Driver Support")
 > Signed-off-by: Ethan Nelson-Moore <enelsonmoore@...il.com>

I do not have access to a SR9700 device (and haven't touched anything
dm9601 related for a long time), but the above sounds sensible, so:

Acked-by: Peter Korsgaard <peter@...sgaard.com>

-- 
Bye, Peter Korsgaard